Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Replace link-to routes with the appropriate locator #157985

Closed
2 tasks done
mohamedhamed-ahmed opened this issue May 17, 2023 · 3 comments · Fixed by #158994
Closed
2 tasks done

[Logs UI] Replace link-to routes with the appropriate locator #157985

mohamedhamed-ahmed opened this issue May 17, 2023 · 3 comments · Fixed by #158994
Assignees
@mohamedhamed-ahmed
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented May 17, 2023 •
edited
Loading

📝 Summary

After the implementation of 104855 in this PR we need to replace all usages of link-to routes to use the newly implemented logs locators

✔️ Acceptance criteria

Note:

Once this is done we should ping the Upgrade Assistant team to update their hardcoded links to our app.
@mohamedhamed-ahmed mohamedhamed-ahmed added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels May 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@mohamedhamed-ahmed mohamedhamed-ahmed changed the title [Logs UI] Register Kibana locators to allow linking to the Logs UI [Logs UI] Replace link-to routes with the usage of the appropriate locator May 17, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed changed the title [Logs UI] Replace link-to routes with the usage of the appropriate locator [Logs UI] Replace link-to routes with the appropriate locator May 17, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this May 17, 2023
This was referenced May 24, 2023
Merged
Merged
Merged
mohamedhamed-ahmed added a commit that referenced this issue May 25, 2023
@mohamedhamed-ahmed @kibanamachine
[Logs+] Replace Monitoring usages of link-to routes (#158367)
43d751e 
part of #157985

## 📝  Summary

After implementing [infra
locators](#155156) to allow
navigation to the logs UI we need to replace all usages of the old
link-to routes so that we have strongly typed navigation to the logs UI.

This PR focuses on replacing `link-to` usages in the Monitoring plugin.

## ✅  Testing

1. Navigate to Stack Monitoring
2. Choose any of the clusters from the list
3. Click logs under Elasticsearch
4. Scroll to the Recent Log Entries section 
5. click on the Logs link `Visit Logs to dive deeper.`



https://github.com/elastic/kibana/assets/11225826/b54da395-4693-4588-a8a3-6b05fdfed1c5

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
mohamedhamed-ahmed added a commit that referenced this issue May 30, 2023
@mohamedhamed-ahmed
[APM UI] Replace logs link-to routes with appropriate locator (#158365)
adb05f6 
part of #157985

## 📝  Summary

After implementing [infra
locators](#155156) to allow
navigation to the logs UI we need to replace all usages of the old
link-to routes so that we have strongly typed navigation to the logs UI.

This PR focuses on replacing `link-to` usages in the APM plugin.

## ✅  Testing

1. Navigate to APM -> Services
2. Follow video below to navigate to where the logs links are located
3. Links should behave as before and maintain navigation params



https://github.com/elastic/kibana/assets/11225826/c631ea31-c5d9-4d05-9219-7b208daf2c37
mohamedhamed-ahmed added a commit that referenced this issue May 30, 2023
@mohamedhamed-ahmed
[Logs+] Replace infra public usages of link-to routes (#158362)
c06b5ef 
part of #157985

## 📝  Summary

After implementing [infra
locators](#155156) to allow
navigation to the logs UI we need to replace all usages of the old
link-to routes so that we have strongly typed navigation to the logs UI.

This PR focuses on replacing `link-to` usages in the Infra Public
plugin.

## ✅  Testing

A) 
1. Navigate to Observability -> Infrastructure -> Inventory
2. Choose any of the Host from the waffle
3. Click logs tab
4. Click open in logs link

B) 
1. Navigate to Observability -> Infrastructure -> Inventory
2. Switch to table view
3. Click any of the Host from the table
4. Click Host Logs


https://github.com/elastic/kibana/assets/11225826/6646c496-1760-4788-9532-b318487070d1
@mohamedhamed-ahmed mohamedhamed-ahmed mentioned this issue Jun 4, 2023
Merged
@mohamedhamed-ahmed
Copy link
Contributor Author

@weltenwort
Regarding Once this is done we should ping the Upgrade Assistant team to update their hardcoded links to our app.
Do we need to do something here?

@weltenwort
Copy link
Member

🤔 I don't remember the context for that. Maybe we should try to find the code owner for the upgrade assistant and ask what they think.

mohamedhamed-ahmed added a commit that referenced this issue Jun 8, 2023
@mohamedhamed-ahmed
[Logs+] Replace usages of link-to routes in infra server (#158994)
3785c93 
closes [#157985](#157985)

## 📝  Summary

This PR moves the previously implemented [infra
locators](#155156) to infra common
and replaces the last usage of `link-to` routes in the infra public with
the appropriate locator.

## ✅  Testing

1. Navigate to Observability Alerts
2. Create a new Log Threshold Rule that should fire
3. Open the alert details flyout
4. Click on the `View in app` button
5. Should correctly navigate to Stream view or Discover in case of
serverless.
* All other links to Logs should still work properly as before as well 



https://github.com/elastic/kibana/assets/11225826/9af85ea6-5fdd-4505-9707-6489b760f311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohamedhamed-ahmed mohamedhamed-ahmed

Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs+] Replace usages of link-to routes in infra server mohamedhamed-ahmed/kibana
3 participants
@weltenwort @mohamedhamed-ahmed @elasticmachine