[ResponseOps] Throwing a mustache error when validating action message for warnings #158666
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Comments
doakalexi
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
1 task
doakalexi
added a commit
that referenced
this issue
May 31, 2023
…e for warnings (#158668) Resolves #158666 ## Summary Adds a try/catch around `mustache.parse` to catch and ignore any errors when validating the action message for warnings. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### To verify - Create a rule and add a slack connector, and open dev tools console - In the action message type `{{` - verify that an error is not thrown and that you can add the second open curly brace
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 31, 2023
…e for warnings (elastic#158668) Resolves elastic#158666 ## Summary Adds a try/catch around `mustache.parse` to catch and ignore any errors when validating the action message for warnings. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### To verify - Create a rule and add a slack connector, and open dev tools console - In the action message type `{{` - verify that an error is not thrown and that you can add the second open curly brace (cherry picked from commit 15b31c6)
kibanamachine
added a commit
that referenced
this issue
May 31, 2023
…message for warnings (#158668) (#158776) # Backport This will backport the following commits from `main` to `8.8`: - [[ResponseOps] Throwing a mustache error when validating action message for warnings (#158668)](#158668) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexi Doak","email":"109488926+doakalexi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-31T20:26:24Z","message":"[ResponseOps] Throwing a mustache error when validating action message for warnings (#158668)\n\nResolves #158666 Summary\r\n\r\nAdds a try/catch around `mustache.parse` to catch and ignore any errors\r\nwhen validating the action message for warnings.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n- Create a rule and add a slack connector, and open dev tools console\r\n- In the action message type `{{` - verify that an error is not thrown\r\nand that you can add the second open curly brace","sha":"15b31c62ba8d4a115c359d9bb723147866bbd34c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:ResponseOps","v8.9.0","v8.8.1"],"number":158668,"url":"#158668 Throwing a mustache error when validating action message for warnings (#158668)\n\nResolves #158666 Summary\r\n\r\nAdds a try/catch around `mustache.parse` to catch and ignore any errors\r\nwhen validating the action message for warnings.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n- Create a rule and add a slack connector, and open dev tools console\r\n- In the action message type `{{` - verify that an error is not thrown\r\nand that you can add the second open curly brace","sha":"15b31c62ba8d4a115c359d9bb723147866bbd34c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#158668 Throwing a mustache error when validating action message for warnings (#158668)\n\nResolves #158666 Summary\r\n\r\nAdds a try/catch around `mustache.parse` to catch and ignore any errors\r\nwhen validating the action message for warnings.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### To verify\r\n\r\n- Create a rule and add a slack connector, and open dev tools console\r\n- In the action message type `{{` - verify that an error is not thrown\r\nand that you can add the second open curly brace","sha":"15b31c62ba8d4a115c359d9bb723147866bbd34c"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexi Doak <109488926+doakalexi@users.noreply.github.com>
sloanelybutsurely
pushed a commit
to sloanelybutsurely/kibana
that referenced
this issue
Jun 6, 2023
…e for warnings (elastic#158668) Resolves elastic#158666 ## Summary Adds a try/catch around `mustache.parse` to catch and ignore any errors when validating the action message for warnings. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### To verify - Create a rule and add a slack connector, and open dev tools console - In the action message type `{{` - verify that an error is not thrown and that you can add the second open curly brace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should catch any error that is thrown when validating for the
server.publicBaseUrlwarning.The text was updated successfully, but these errors were encountered: