Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Rename offering specific plugins #159685

Closed
semd opened this issue Jun 14, 2023 · 1 comment · Fixed by #161153
Closed

[Security Solution] Rename offering specific plugins #159685

semd opened this issue Jun 14, 2023 · 1 comment · Fixed by #161153
Assignees
@semd
Labels
8.10 candidate Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@semd
Copy link
Contributor

semd commented Jun 14, 2023 •
edited

Summary

In order to avoid confusing the new SecuritySolution offering plugins with the security plugin, we need to rename:

serverless_security -> security_solution_serverless
ess_security -> security_solution_ess

the plugins config prefixes will also need to be updated:

security_solution_serverless: xpack.serverless.security.* -> xpack.securitySolutionServerless.*
security_solution_ess: xpack.ess.security.* -> xpack.securitySolutionEss.*
@semd semd added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Jun 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd semd self-assigned this Jun 23, 2023
@semd semd mentioned this issue Jul 4, 2023
Merged
semd added a commit that referenced this issue Jul 5, 2023
@semd @kibanamachine
[SecuritySolution] Rename security solution plugins (#161153)
f2e773d 
## Summary

closes: #159685

- Renaming _x-pack/plugins_:
`serverless_security` -> `security_solution_serverless`
`ess_security` -> `security_solution_ess`

- All the related configurations and types have also been renamed.
- i18n translation prefixes updated
- relocation of internal `security_solution_serverless` directories to
be consistent with `security_solution_ess`

### Eslint
I also added the plugins in the `.eslintrc` configuration, defining the
same rules as the `security_solution` plugin.
All eslint errors have been addressed (mainly _type_ imports errors)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@semd semd

Labels
8.10 candidate Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SecuritySolution] Rename security solution plugins semd/kibana
2 participants
@elasticmachine @semd