Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualizations] Add API integration tests #161038

Open
1 of 4 tasks
drewdaemon opened this issue Jun 30, 2023 · 3 comments
Open
1 of 4 tasks

[Visualizations] Add API integration tests #161038

drewdaemon opened this issue Jun 30, 2023 · 3 comments
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Jun 30, 2023 •
edited

Describe the feature:
With #157043, all our content types got custom API layers. While (many of) these APIs are tested implicitly with the existing functional test suite, we could consider API integration tests (making requests and verifying the responses without involving the UI).

Other teams in Kibana that maintain their own endpoints employ this strategy to verify the behavior of the API layer relatively inexpensively (e.g. https://github.com/elastic/kibana/blob/main/x-pack/test/api_integration/apis/ml/jobs/force_start_datafeeds.ts).

Could also consider how this intersects with the docs team's requests to document our APIs via the OpenAPI spec.
@drewdaemon drewdaemon added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@timductive timductive added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jul 26, 2023
@drewdaemon
Copy link
Contributor Author

Made a start for the event annotations here.

@drewdaemon drewdaemon mentioned this issue Sep 14, 2023
Merged
drewdaemon added a commit that referenced this issue Sep 18, 2023
@drewdaemon @kibanamachine
[Event annotations] add more API integration tests (#166463)
6d47334 
## Summary

Covers the event annotations API in tests.

Part of #159053
Part of #161038

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@drewdaemon drewdaemon added loe:large Large Level of Effort and removed loe:x-large Extra Large Level of Effort labels Sep 27, 2023
@drewdaemon
Copy link
Contributor Author

Good case to cover: #166919

@stratoula stratoula added loe:medium Medium Level of Effort and removed loe:large Large Level of Effort labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drewdaemon @timductive @elasticmachine @stratoula