[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page #161456
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
fixed
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
QA:Validated
Issue has been validated by QA
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Comments
vgomez-el
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
vgomez-el
added
the
impact:high
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Related: #160561 |
|
@marshallmain thanks for adding related ticket. I also discovered yesterday that it happens due to memoization and if I disable it for the whole about page then everything works again. Will try to find a way to minimize memoization disabling which we need to fix the issue. I guess the plan is to fix it correctly inside EUI at some point, so it will be just a workaround for now (will add a comment about that). |
e40pud
added a commit
to e40pud/kibana
that referenced
this issue
Jul 12, 2023
…on Rule Creation page (elastic#161456)
e40pud
added a commit
that referenced
this issue
Jul 18, 2023
…on Rule Creation page (#161793) ## Summary Original ticket: #161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in #160561 and elastic/eui#6846) Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jul 18, 2023
…on Rule Creation page (elastic#161793) ## Summary Original ticket: elastic#161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in elastic#160561 and elastic/eui#6846) Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com> (cherry picked from commit 731f587)
kibanamachine
added a commit
that referenced
this issue
Jul 18, 2023
…rlaid on Rule Creation page (#161793) (#162138) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)](#161793) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-07-18T12:36:07Z","message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)\n\n## Summary\r\n\r\nOriginal ticket: #161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>","sha":"731f5879799b6d2e1e35a4c24cf6440fc60a631a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:cloud-deploy","Team:Detection Engine","v8.10.0","v8.9.1"],"number":161793,"url":"#161793 Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)\n\n## Summary\r\n\r\nOriginal ticket: #161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>","sha":"731f5879799b6d2e1e35a4c24cf6440fc60a631a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#161793 Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)\n\n## Summary\r\n\r\nOriginal ticket: #161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>","sha":"731f5879799b6d2e1e35a4c24cf6440fc60a631a"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
|
@MadameSheema @vgomez-el the fix has been merged in both |
|
Thank you @e40pud! I will validate this bug fix on the 8.9 BC5 once we have it 😄 |
|
It looks nice to me on 8.9 BC5, so we can consider this bug as fixed and Validated by QA |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this issue
Aug 1, 2023
…on Rule Creation page (elastic#161793) ## Summary Original ticket: elastic#161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in elastic#160561 and elastic/eui#6846) Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
The issue appeared again in latest |
vgomez-el
added
triage_needed
and removed
fixed
QA:Validated
|
@e40pud can we revisit this bug? We can follow up post 8.12 FF as well. |
|
Will check for QA Validation once confirmation of bug 🐛 fix in 8.12 or later |
e40pud
added a commit
to e40pud/kibana
that referenced
this issue
Dec 6, 2023
…on Rule Creation page (elastic#161456)
e40pud
added a commit
that referenced
this issue
Dec 12, 2023
…on Rule Creation page (#161456) (#172677) ## Summary Addresses #161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in #160561 and elastic/eui#6846) The fix is to forcibly remove/add EuiRange component on About step activation. Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 12, 2023
…on Rule Creation page (elastic#161456) (elastic#172677) ## Summary Addresses elastic#161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in elastic#160561 and elastic/eui#6846) The fix is to forcibly remove/add EuiRange component on About step activation. Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> (cherry picked from commit 28d18e8)
kibanamachine
added a commit
that referenced
this issue
Dec 12, 2023
…erlaid on Rule Creation page (#161456) (#172677) (#173140) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)](#172677) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-12-12T10:29:50Z","message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses #161456 changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","v8.13.0"],"number":172677,"url":"#172677 Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses #161456 changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172677","number":172677,"mergeCommit":{"message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses #161456 changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
|
@MadameSheema @cybersecdiva @vgomez-el the fix was merged into |
|
It is fixed and validated in 8.12 BC 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
Default Risk score slide bar values are overlapped on Rule Creation page
Kibana/Elasticsearch Stack version:
8.9.0 BC 3
Server OS version:
Cloud instance
Browser and Browser OS versions:
Google Chrome Version 114.0.5735.133 (Official build) (arm64)
Original install method (e.g. download page, yum, from source, etc.):
Cloud deployment
Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Rule creation
Steps to reproduce:
Current behavior:
All the slide bar values are overlaid on left. Check attached screenshot for more details
Expected behavior:
Values should be displayed properly
Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: