Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/bundled_prebuilt_rules_package/prerelease_packages·ts - prerelease_packages should install latest stable version and ignore prerelease packages #162192

Closed
Tracked by #165359
kibanamachine opened this issue Jul 18, 2023 · 5 comments · Fixed by #169780
Closed
Tracked by #165359

Failing test: X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/bundled_prebuilt_rules_package/prerelease_packages·ts - prerelease_packages should install latest stable version and ignore prerelease packages #162192

kibanamachine opened this issue Jul 18, 2023 · 5 comments · Fixed by #169780
Assignees
@jpdjere
Labels
8.12 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 18, 2023 •
edited

A test failed on a tracked branch

JestAssertionError: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0
    at Context.<anonymous> (prerelease_packages.ts:49:62)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (wrap_function.js:73:16) {
  matcherResult: {
    actual: 0,
    expected: 1,
    message: '\x1B[2mexpect(\x1B[22m\x1B[31mreceived\x1B[39m\x1B[2m).\x1B[22mtoBe\x1B[2m(\x1B[22m\x1B[32mexpected\x1B[39m\x1B[2m) // Object.is equality\x1B[22m\n' +
      '\n' +
      'Expected: \x1B[32m1\x1B[39m\n' +
      'Received: \x1B[31m0\x1B[39m',
    name: 'toBe',
    pass: false
  }
}

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 18, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 18, 2023
@kibanamachine kibanamachine added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Jul 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 18, 2023
@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team labels Jul 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@e40pud e40pud self-assigned this Jul 19, 2023
@e40pud
Copy link
Contributor

e40pud commented Jul 19, 2023

Fixed by #161802
cc @jpdjere

@e40pud e40pud closed this as completed Jul 19, 2023
@kibanamachine kibanamachine reopened this Sep 7, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@banderror banderror assigned maximpn and unassigned e40pud Sep 7, 2023
@banderror banderror added Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules 8.11 candidate and removed triage_needed labels Sep 7, 2023
@banderror banderror mentioned this issue Sep 7, 2023
Closed
@maximpn maximpn assigned jpdjere and unassigned maximpn Oct 16, 2023
@jpdjere jpdjere mentioned this issue Oct 25, 2023
Merged
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

jpdjere added a commit that referenced this issue Oct 30, 2023
@jpdjere
[Security Solution ] Fix flake in `bundled_prebuilt_rules_package/pre…
d1b7b7f 
…release_packages.ts` API Integration test (#169780)

Fixes: #162192

## Summary

Removes flake by explicitly calling the Fleet endpoint to install the
latest package, and doing assertions before actually installing the
rules.

Previously we were calling directly `installPrebuiltRules` without
having explicitly installed the package before. The old installation
endpoint would check that the package was installed before proceeding,
but the new install method doesn't. So the explicit installation is
required.

## Flaky test runs

-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3721~
-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3730
[CONTROL - NO CHANGES]~
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3773
[After refactor]
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 30, 2023
@jpdjere
[Security Solution ] Fix flake in `bundled_prebuilt_rules_package/pre…
450314b 
…release_packages.ts` API Integration test (elastic#169780)

Fixes: elastic#162192

## Summary

Removes flake by explicitly calling the Fleet endpoint to install the
latest package, and doing assertions before actually installing the
rules.

Previously we were calling directly `installPrebuiltRules` without
having explicitly installed the package before. The old installation
endpoint would check that the package was installed before proceeding,
but the new install method doesn't. So the explicit installation is
required.

## Flaky test runs

-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3721~
-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3730
[CONTROL - NO CHANGES]~
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3773
[After refactor]

(cherry picked from commit d1b7b7f)
fkanout pushed a commit to fkanout/kibana that referenced this issue Oct 30, 2023
@jpdjere @fkanout
[Security Solution ] Fix flake in `bundled_prebuilt_rules_package/pre…
3f2318b 
…release_packages.ts` API Integration test (elastic#169780)

Fixes: elastic#162192

## Summary

Removes flake by explicitly calling the Fleet endpoint to install the
latest package, and doing assertions before actually installing the
rules.

Previously we were calling directly `installPrebuiltRules` without
having explicitly installed the package before. The old installation
endpoint would check that the package was installed before proceeding,
but the new install method doesn't. So the explicit installation is
required.

## Flaky test runs

-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3721~
-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3730
[CONTROL - NO CHANGES]~
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3773
[After refactor]
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Oct 30, 2023
@jpdjere @bryce-b
[Security Solution ] Fix flake in `bundled_prebuilt_rules_package/pre…
fd7cace 
…release_packages.ts` API Integration test (elastic#169780)

Fixes: elastic#162192

## Summary

Removes flake by explicitly calling the Fleet endpoint to install the
latest package, and doing assertions before actually installing the
rules.

Previously we were calling directly `installPrebuiltRules` without
having explicitly installed the package before. The old installation
endpoint would check that the package was installed before proceeding,
but the new install method doesn't. So the explicit installation is
required.

## Flaky test runs

-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3721~
-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3730
[CONTROL - NO CHANGES]~
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3773
[After refactor]
awahab07 pushed a commit to awahab07/kibana that referenced this issue Oct 31, 2023
@jpdjere @awahab07
[Security Solution ] Fix flake in `bundled_prebuilt_rules_package/pre…
42330d0 
…release_packages.ts` API Integration test (elastic#169780)

Fixes: elastic#162192

## Summary

Removes flake by explicitly calling the Fleet endpoint to install the
latest package, and doing assertions before actually installing the
rules.

Previously we were calling directly `installPrebuiltRules` without
having explicitly installed the package before. The old installation
endpoint would check that the package was installed before proceeding,
but the new install method doesn't. So the explicit installation is
required.

## Flaky test runs

-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3721~
-
~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3730
[CONTROL - NO CHANGES]~
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3773
[After refactor]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpdjere jpdjere

Labels
8.12 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
7 participants
@e40pud @maximpn @jpdjere @banderror @elasticmachine @MadameSheema @kibanamachine