Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Action menu overlaps the flyout #162224

Closed
kpatticha opened this issue Jul 19, 2023 · 5 comments · Fixed by #162664
Closed

[APM] Action menu overlaps the flyout #162224

kpatticha opened this issue Jul 19, 2023 · 5 comments · Fixed by #162664
Assignees
@achyutjhunjhunwala
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM All issues that need APM UI Team support

Comments

@kpatticha
Copy link
Contributor

Screen.Recording.2023-07-19.at.10.44.50.mov

Reproduce

  1. Trace explorer
  2. Investigate
  3. Create custom links

The issue was found on 8.10 but it might be present in previous versions. I would expect the issue to appear in places where we show the Investigate button such as transaction waterfall

Solution

The action menu to be hidden once the flyout is open
@kpatticha kpatticha added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM All issues that need APM UI Team support labels Jul 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@Ruhshan
Copy link
Contributor

Ruhshan commented Jul 20, 2023

Hi @kpatticha ,
wanted to work on this. I'm currently on latest main branch. But has anything changed? Not finding the create custom links option in investigate pop up. Or am i missing any settings?

image

@kpatticha
Copy link
Contributor Author

Thanks for checking it @Ruhshan .

The custom links feature is available on gold licence. You need to start elastic search with trial.

yarn es snapshot --license trial

Let me know if you have any issues.

@Ruhshan
Copy link
Contributor

Ruhshan commented Jul 26, 2023

Thanks for checking it @Ruhshan .

The custom links feature is available on gold licence. You need to start elastic search with trial.

yarn es snapshot --license trial

Let me know if you have any issues.

Thank you, found it.

@Ruhshan Ruhshan mentioned this issue Jul 27, 2023
Merged
3 tasks
@Ruhshan
Copy link
Contributor

Ruhshan commented Jul 27, 2023

Hi @kpatticha , can you please check my PR.

achyutjhunjhunwala added a commit that referenced this issue Aug 11, 2023
@Ruhshan @achyutjhunjhunwala @kibanamachine
162224 fix action menu overlaps flyout (#162664)
a29e4aa 
## Summary

Fixes #162224.

Currently when **create custom link** button is clicked, though the
flyout opens, but action menu persisted over the flyout making the
create custom link flyout unusable.

On this PR necessary restructuring and refactoring was done to fix this
behavior.

[Screencast from 07-28-2023 01:52:15
AM.webm](https://github.com/elastic/kibana/assets/5312918/33b7ad00-d10f-41dc-9901-1ccf3006e895)


### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
benakansara pushed a commit to benakansara/kibana that referenced this issue Aug 14, 2023
@Ruhshan @achyutjhunjhunwala
@kibanamachine @benakansara
162224 fix action menu overlaps flyout (elastic#162664)
4064823 
## Summary

Fixes elastic#162224.

Currently when **create custom link** button is clicked, though the
flyout opens, but action menu persisted over the flyout making the
create custom link flyout unusable.

On this PR necessary restructuring and refactoring was done to fix this
behavior.

[Screencast from 07-28-2023 01:52:15
AM.webm](https://github.com/elastic/kibana/assets/5312918/33b7ad00-d10f-41dc-9901-1ccf3006e895)


### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

162224 fix action menu overlaps flyout Ruhshan/kibana
4 participants
@kpatticha @Ruhshan @achyutjhunjhunwala @elasticmachine