Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EsAggs] Improve agg performance setting track_total_hits to false #164194

Open
3 tasks
dej611 opened this issue Aug 17, 2023 · 1 comment · May be fixed by #165060
Open
3 tasks

[EsAggs] Improve agg performance setting track_total_hits to false #164194

dej611 opened this issue Aug 17, 2023 · 1 comment · May be fixed by #165060
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@dej611
Copy link
Contributor

dej611 commented Aug 17, 2023

Describe the feature:

Any aggregation only search request’s (size=0) performance can be improved by setting ‘track_total_hits’ to ‘false’.
This was also confirmed by ES team.
It would be nice to find all those opportunities on our side to leverage it for speed-ups.

@thomasneirynck reported that Maps is already using this.
From my first investigation Lens is simply relying on the default of the esAggs code, which should be true.

Tasks:

  • investigate those aggs who require a precise total hits value
  • add some logic to detect whether it's possible to disable the flag
  • measure the speed-ups?
    • perhaps add it to the performance journey job?
@dej611 dej611 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@kibanamachine kibanamachine added this to Long-term goals in Lens Aug 17, 2023
@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Aug 17, 2023
@ppisljar ppisljar linked a pull request Aug 29, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Long-term goals
Development

Successfully merging a pull request may close this issue.

3 participants