Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not tracking totalHits if size is 0 #165060

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ppisljar
Copy link
Member

Summary

resolves #164194

Checklist

Delete any items that are not applicable to this PR.

@ppisljar ppisljar added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 labels Aug 29, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 18, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / context api createSearchSource when useFieldsApi is false
  • [job] [logs] Jest Tests #13 / context api createSearchSource when useFieldsApi is true
  • [job] [logs] Jest Tests #13 / context app function fetchAnchor should update search source correctly when useNewFieldsApi set to false
  • [job] [logs] Jest Tests #13 / context app function fetchAnchor should update search source correctly when useNewFieldsApi set to true
  • [job] [logs] FTR Configs #49 / data plugin data.search searchSource createEmpty()
  • [job] [logs] FTR Configs #49 / data plugin data.search searchSource createEmpty()
  • [job] [logs] Jest Tests #7 / getQueryFromSavedSearchObject() should return parsed searchSourceJSON with query and filter
  • [job] [logs] Jest Tests #13 / getSharingData getSearchSource does not add fields to the searchSource
  • [job] [logs] Jest Tests #13 / getSharingData getSearchSource does not add fields to the searchSource with 'discover:searchFieldsFromSource=true'
  • [job] [logs] Jest Tests #2 / Saved Object save to extract references when indexes exists in filter of searchSourceJSON
  • [job] [logs] Jest Tests #2 / Saved Object save to extract references when search source references saved object
  • [job] [logs] Jest Tests #11 / saved_searches_utils fromSavedSearchAttributes should convert attributes into SavedSearch
  • [job] [logs] Jest Tests #11 / SearchSource #serialize should add pit
  • [job] [logs] Jest Tests #11 / SearchSource #serialize should omit size but not sort
  • [job] [logs] Jest Tests #11 / SearchSource getSerializedFields should return serialized fields

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2577 2579 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 407.5KB 407.8KB +242.0B
Unknown metric groups

API count

id before after diff
data 3308 3310 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar removed the v8.11.0 label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EsAggs] Improve agg performance setting track_total_hits to false
2 participants