Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDocViewer] Support wildcard fieldname search #168607

Closed
Tracked by #163284
jughosta opened this issue Oct 11, 2023 · 1 comment · Fixed by #168616
Closed
Tracked by #163284

[UnifiedDocViewer] Support wildcard fieldname search #168607

jughosta opened this issue Oct 11, 2023 · 1 comment · Fixed by #168616
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
Discover

Comments

@jughosta
Copy link
Contributor

We could adopt the same behaviour as in the UnifiedFieldList to allow using * and while searching for a field by its name.

Previous PRs:
@jughosta jughosta added enhancement New value added to drive a business result Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Feature:UnifiedDocViewer Issues relating to the unified doc viewer component labels Oct 11, 2023
@jughosta jughosta self-assigned this Oct 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine kibanamachine added this to Inbox in Discover Oct 11, 2023
@jughosta jughosta mentioned this issue Oct 11, 2023
Merged
2 tasks
@kertal kertal added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 16, 2023
@kertal kertal mentioned this issue Oct 18, 2023
Open
jughosta added a commit that referenced this issue Oct 18, 2023
@jughosta @kibanamachine @kertal
[UnifiedDocViewer] Field search via wildcard (#168616)
54fd403 
- Closes #168607

## Summary

This PR allows to search in DocViewer not only for partial matches but
also for wildcard matches.

<img width="400" alt="Screenshot 2023-10-11 at 16 51 36"
src="https://github.com/elastic/kibana/assets/1415710/ec5dc57f-e540-48c6-b43c-d79d64ef1809">
<img width="400" alt="Screenshot 2023-10-11 at 16 51 48"
src="https://github.com/elastic/kibana/assets/1415710/c68a3b70-c195-4da9-bb0c-12ca38db269c">
<img width="400" alt="Screenshot 2023-10-11 at 16 52 24"
src="https://github.com/elastic/kibana/assets/1415710/d2d37976-559d-4cc3-852f-5ad3175808cc">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
benakansara pushed a commit to benakansara/kibana that referenced this issue Oct 22, 2023
@jughosta @kibanamachine
@kertal @benakansara
[UnifiedDocViewer] Field search via wildcard (elastic#168616)
086e877 
- Closes elastic#168607

## Summary

This PR allows to search in DocViewer not only for partial matches but
also for wildcard matches.

<img width="400" alt="Screenshot 2023-10-11 at 16 51 36"
src="https://github.com/elastic/kibana/assets/1415710/ec5dc57f-e540-48c6-b43c-d79d64ef1809">
<img width="400" alt="Screenshot 2023-10-11 at 16 51 48"
src="https://github.com/elastic/kibana/assets/1415710/c68a3b70-c195-4da9-bb0c-12ca38db269c">
<img width="400" alt="Screenshot 2023-10-11 at 16 52 24"
src="https://github.com/elastic/kibana/assets/1415710/d2d37976-559d-4cc3-852f-5ad3175808cc">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
benakansara pushed a commit to benakansara/kibana that referenced this issue Oct 22, 2023
@jughosta @kibanamachine
@kertal @benakansara
[UnifiedDocViewer] Field search via wildcard (elastic#168616)
4169e75 
- Closes elastic#168607

## Summary

This PR allows to search in DocViewer not only for partial matches but
also for wildcard matches.

<img width="400" alt="Screenshot 2023-10-11 at 16 51 36"
src="https://github.com/elastic/kibana/assets/1415710/ec5dc57f-e540-48c6-b43c-d79d64ef1809">
<img width="400" alt="Screenshot 2023-10-11 at 16 51 48"
src="https://github.com/elastic/kibana/assets/1415710/c68a3b70-c195-4da9-bb0c-12ca38db269c">
<img width="400" alt="Screenshot 2023-10-11 at 16 52 24"
src="https://github.com/elastic/kibana/assets/1415710/d2d37976-559d-4cc3-852f-5ad3175808cc">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Discover
Inbox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UnifiedDocViewer] Field search via wildcard jughosta/kibana
3 participants
@kertal @jughosta @elasticmachine