Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn how many objects or list objects affected when deleting a kibana object that is referenced by other objects such as an index pattern #16912

Closed
geekpete opened this issue Feb 25, 2018 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@geekpete
Copy link
Member

It might be useful to warn that x number of objects are referencing an object before deleting referenced kibana objects (mostly thinking of index patterns here but potentially searches, visualisations too?).
Perhaps even list the objects that are referencing the object targetted for deletion so decisions can be made before the delete is executed.
This is to avoid having a potential set of objects reference a non-existent object/pattern.

This is especially important for index patterns, since there's not yet any official process to change an index pattern for existing objects or repair existing objects that reference a non-existent index pattern as per: #3668

Though there is a way to manually fix such a situation where by manually editing the kibana object documents directly that reference the index pattern to use the new index pattern UUID or creating a new pattern object and overwritting the UUID field of the new pattern object document with the UUID value that existing objects still reference. A way to batch change this easily for a given set of objects might be super handy as indicated by the number of comments on the existing issue I mentioned.

v5.6.8 asks "Are you sure you want to remove this index pattern?"
v6.2.1 asks "Delete index pattern?"

at this point it'd be great to have a list of rammifications/what will be affected by this change, since the impact could potentially be large.

I do see the useful workaround for this scenario in 5.6.8 where a visualisation says an index pattern is missing do you want to recreate it, then offers to use the existing UUID for the newly created index pattern. This would help solve this issue once it's occurred, but thinking of a preventative feature here.

@chrisronline
Copy link
Contributor

I love it. It feels related to #5947, #3127, #8804, and #16747 to some degree, but we definitely want to do a better job of surfacing and building tooling around these relationships.

@geekpete
Copy link
Member Author

geekpete commented Mar 13, 2018

Yeah looks like it would definitely tie into those other ideas of surfacing relationships between objects, these are cool ideas for sure!

@spalger spalger removed the v6.6.0 label Aug 14, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages and removed :Management DO NOT USE labels Nov 27, 2018
@geekpete
Copy link
Member Author

geekpete commented Feb 25, 2021

@chrisronline Though all the referenced issues in your last comment are now closed, it seems in 7.11.1 we still don't warn of the full impact of deleting an object:

2021-02-25_11-48

and

2021-02-25_11-49

In a related context there was also the other issue of how you fix things once you have done a delete that breaks stuff, this issue was something that people were hoping for:
#17542

But was essentially replaced by Lens functionality that lets you pick index pattern from the dropdown.

Testing with deleting an index pattern that is referenced from a visualisation seems that you cannot even repair it now whereas a few versions back this seemed possible by selecting a replacement index pattern to update the visualisation with.
The behaviour now for Lens is to give up when loading a saved Lens visualisation and reset the visualisation options even if you select a replacement index pattern in the dropdown:

2021-02-25_11-56

2021-02-25_11-56_1

and the behaviour of aggregation visualisations, when you load a visualisation that points to a now non-existent index pattern:

2021-02-25_11-59

when clicking the "re-create" link in the bottom right, you're sent across to the Saved Objects Management UI where you cannot create anything. This "re-create" functionality seems now disconnected from the repair step that it used let you do.

Tested on 7.11.1, but seems like a regression of functionality that used to work (repair objects by recreating index pattern that is now missing?)

@flash1293 flash1293 added Team:AppServicesSv Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@ppisljar
Copy link
Member

ppisljar commented Aug 9, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

9 participants