Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM][Maintenance Window] Fix MW front-end types and transforms #172529

Closed
JiaweiWu opened this issue Dec 4, 2023 · 1 comment · Fixed by #173888
Closed

[RAM][Maintenance Window] Fix MW front-end types and transforms #172529

JiaweiWu opened this issue Dec 4, 2023 · 1 comment · Fixed by #173888
Assignees
@JiaweiWu
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX refactoring Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@JiaweiWu
Copy link
Contributor

JiaweiWu commented Dec 4, 2023 •
edited
Loading

We have some incomplete and incorrect front-end MW typings. We should fix that and use the same transforms.
@JiaweiWu JiaweiWu self-assigned this Dec 4, 2023
@JiaweiWu JiaweiWu added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX labels Dec 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@JiaweiWu JiaweiWu mentioned this issue Dec 22, 2023
Merged
1 task
JiaweiWu added a commit that referenced this issue Jan 24, 2024
@JiaweiWu @kibanamachine
[RAM][Maintenance Window] Fix maintenance window FE types and transfo…
891cbfa 
…rms (#173888)

## Summary
Resolves: #172529

Fix up some odd types for the maintenance window frontend. Consolidates
some response transforms.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lcawl pushed a commit to lcawl/kibana that referenced this issue Jan 26, 2024
@JiaweiWu @kibanamachine @lcawl
[RAM][Maintenance Window] Fix maintenance window FE types and transfo…
1036ccc 
…rms (elastic#173888)

## Summary
Resolves: elastic#172529

Fix up some odd types for the maintenance window frontend. Consolidates
some response transforms.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@JiaweiWu @kibanamachine @CoenWarmer
[RAM][Maintenance Window] Fix maintenance window FE types and transfo…
b17559e 
…rms (elastic#173888)

## Summary
Resolves: elastic#172529

Fix up some odd types for the maintenance window frontend. Consolidates
some response transforms.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@JiaweiWu @kibanamachine @CoenWarmer
[RAM][Maintenance Window] Fix maintenance window FE types and transfo…
f4bfeb7 
…rms (elastic#173888)

## Summary
Resolves: elastic#172529

Fix up some odd types for the maintenance window frontend. Consolidates
some response transforms.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaweiWu JiaweiWu

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX refactoring Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM][Maintenance Window] Fix maintenance window FE types and transforms JiaweiWu/kibana
2 participants
@elasticmachine @JiaweiWu