Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view/components - EditTags renders no tags, and then edit #175655

Closed
kibanamachine opened this issue Jan 26, 2024 · 10 comments · Fixed by #175763, #176863 or #186295
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view/components - EditTags renders no tags, and then edit #175655

kibanamachine opened this issue Jan 26, 2024 · 10 comments · Fixed by #175763, #176863 or #186295
Assignees
@adcoelho
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 26, 2024 •
edited
Loading

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at it (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/components/edit_tags.test.tsx:44:3)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at Object.describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/components/edit_tags.test.tsx:28:1)
    at Runtime._execModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1430:24)
    at Runtime._loadModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1013:12)
    at Runtime.requireModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:873:12)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-81f1fb3cd7b73155/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 26, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 26, 2024
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jan 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 26, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@delanni delanni mentioned this issue Jan 26, 2024
Merged
mistic pushed a commit that referenced this issue Jan 26, 2024
@delanni
[tests] skip editTags unit tests for being flaky (#175709)
bb3abc7 
## Summary
The tests started to be flaky recently:
https://ops.kibana.dev/s/ci/app/dashboards#/view/cb7380fb-67fe-5c41-873d-003d1a407dad?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-4w,to:now))

#175618
#175619
#175621
#175622
#175623
#175655
@mistic
Copy link
Member

mistic commented Jan 26, 2024

Skipped.

main: bb3abc7

lcawl pushed a commit to lcawl/kibana that referenced this issue Jan 26, 2024
@delanni @lcawl
[tests] skip editTags unit tests for being flaky (elastic#175709)
58986ab 
## Summary
The tests started to be flaky recently:
https://ops.kibana.dev/s/ci/app/dashboards#/view/cb7380fb-67fe-5c41-873d-003d1a407dad?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-4w,to:now))

elastic#175618
elastic#175619
elastic#175621
elastic#175622
elastic#175623
elastic#175655
@cnasikas cnasikas added the Feature:Cases Cases feature label Jan 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas self-assigned this Jan 29, 2024
@cnasikas cnasikas mentioned this issue Jan 29, 2024
Merged
2 tasks
cnasikas added a commit that referenced this issue Jan 29, 2024
@cnasikas
[Cases] Fix edit tags flaky tests (#175763)
57b4efa 
## Summary

Fixes: #175655,
#175623,
#175622,
#175619,
#175618

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@kibanamachine kibanamachine reopened this Feb 1, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Feb 9, 2024
@mistic
skip flaky suite (#175655)
3503a11
@mistic
Copy link
Member

mistic commented Feb 9, 2024

Skipped.

main: 3503a11

fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@cnasikas @fkanout
[Cases] Fix edit tags flaky tests (elastic#175763)
9844c45 
## Summary

Fixes: elastic#175655,
elastic#175623,
elastic#175622,
elastic#175619,
elastic#175618

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@mistic @fkanout
skip flaky suite (elastic#175655)
8a9c9e0
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@cnasikas @umbopepato
@kibanamachine @fkanout
[Cases] Fix cases flaky tests (elastic#176863)
b8e8fe4 
## Summary

With the help of @umbopepato, @js-jankisalvi, and @adcoelho, we realized
that one possible source of flakiness is the `CasesContextProvider` that
every test uses under the hood. In this PR I refactor the
`CasesContextProvider` to render immediately its children and not wait
for the `appId` and `appTitle` to be defined. I make them optional and
make all changes needed in the code to accommodate the presence of an
optional `appId`. Also, I refactored some components that I believed
could introduce flakiness.

## Issues

Fixes elastic#175570
Fixes elastic#175956
Fixes elastic#175935
Fixes elastic#175934
Fixes elastic#175655
Fixes elastic#176643
Fixes elastic#175204

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5255,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5261,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5264,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5267

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenario

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Umberto Pepato <umberto.pepato@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
eokoneyo pushed a commit to eokoneyo/kibana that referenced this issue Mar 5, 2024
@cnasikas @umbopepato
@kibanamachine @eokoneyo
[Cases] Fix cases flaky tests (elastic#176863)
404abe4 
## Summary

With the help of @umbopepato, @js-jankisalvi, and @adcoelho, we realized
that one possible source of flakiness is the `CasesContextProvider` that
every test uses under the hood. In this PR I refactor the
`CasesContextProvider` to render immediately its children and not wait
for the `appId` and `appTitle` to be defined. I make them optional and
make all changes needed in the code to accommodate the presence of an
optional `appId`. Also, I refactored some components that I believed
could introduce flakiness.

## Issues

Fixes elastic#175570
Fixes elastic#175956
Fixes elastic#175935
Fixes elastic#175934
Fixes elastic#175655
Fixes elastic#176643
Fixes elastic#175204

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5255,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5261,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5264,
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5267

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenario

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Umberto Pepato <umberto.pepato@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine reopened this Mar 11, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Mar 22, 2024
@mistic
skip flaky suite (#175655)
ee9c021
@mistic
Copy link
Member

mistic commented Mar 22, 2024

Skipped.

main: ee9c021

@thomheymann thomheymann mentioned this issue Mar 26, 2024
Merged
@cnasikas cnasikas removed their assignment Apr 21, 2024
@cnasikas cnasikas added v8.15.0 and removed v8.14.0 labels May 15, 2024
@adcoelho adcoelho mentioned this issue Jun 17, 2024
Merged
adcoelho added a commit that referenced this issue Jun 18, 2024
@adcoelho
[ResponseOps][Cases] Fix edit tags flaky test (#186295)
8ad77f6 
Fixes [#175655](#175655)

## Summary

The other tests already tested the edit button so I changed the scope to
look only for the `no tags` message.
nikitaindik pushed a commit to nikitaindik/kibana that referenced this issue Jun 18, 2024
@adcoelho @nikitaindik
[ResponseOps][Cases] Fix edit tags flaky test (elastic#186295)
454574b 
Fixes [elastic#175655](elastic#175655)

## Summary

The other tests already tested the edit button so I changed the scope to
look only for the `no tags` message.
@adcoelho adcoelho self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
5 participants
@adcoelho @mistic @cnasikas @elasticmachine @kibanamachine