Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Monaco Migration] Implement editor features #176723

Closed
7 of 15 tasks
yuliacech opened this issue Feb 12, 2024 · 2 comments
Closed
7 of 15 tasks

[Console Monaco Migration] Implement editor features #176723

yuliacech opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

yuliacech commented Feb 12, 2024

After #176520 is merged, we need to start re-implementing existing editor features from Ace to Monaco. This issue contains a list of tasks that needs to be addressed.
The existing code is located in legacy/console_editor/editor.tsx and need to be copied to or re-implemented in monaco/monaco_editor.tsx in the directory src/plugins/console/public/application/containers/editor. Ideally the UI should not change during the migration but if needed some features could be updated or removed. Some features can be worked on already but some might need a working language definition (see this issue for more details).

Tasks

  1. Feature:Console Team:Kibana Management
    ElenaStoeva
  2. Feature:Console Team:Kibana Management
    ElenaStoeva
  3. Feature:Console Team:Kibana Management
    ElenaStoeva
  4. Feature:Console Team:Kibana Management
    yuliacech
  5. Feature:Console Team:Kibana Management
    ElenaStoeva
  6. Feature:Console Team:Kibana Management
    ElenaStoeva
  7. Feature:Console Team:Kibana Management
  8. 1 of 3
    Feature:Console Team:Kibana Management
  9. 2 of 3
    Feature:Console Team:Kibana Management
    ElenaStoeva
@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Feb 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

yuliacech added a commit that referenced this issue Feb 19, 2024
## Summary

This PR adds a dev config to Console to enable a migration to the Monaco
editor. The config value is `false` by default and can be changed by
adding `console.dev.enableMonaco: true` to `kibana.dev.yml`. Also a new
custom Monaco language is registered for Console in the package
`kbn/monaco` and will be worked on behind the config flag iteratively in
the next weeks.
To not let the dev config get into 8.13 release, this PR will only be
merged **after** 8.13 has been branched.
After this PR is merged, the team will start re-implementing existing
Console features in the new Monaco editor, see
#176723 and
#176926

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
awahab07 pushed a commit to awahab07/kibana that referenced this issue Feb 19, 2024
## Summary

This PR adds a dev config to Console to enable a migration to the Monaco
editor. The config value is `false` by default and can be changed by
adding `console.dev.enableMonaco: true` to `kibana.dev.yml`. Also a new
custom Monaco language is registered for Console in the package
`kbn/monaco` and will be worked on behind the config flag iteratively in
the next weeks.
To not let the dev config get into 8.13 release, this PR will only be
merged **after** 8.13 has been branched.
After this PR is merged, the team will start re-implementing existing
Console features in the new Monaco editor, see
elastic#176723 and
elastic#176926

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
## Summary

This PR adds a dev config to Console to enable a migration to the Monaco
editor. The config value is `false` by default and can be changed by
adding `console.dev.enableMonaco: true` to `kibana.dev.yml`. Also a new
custom Monaco language is registered for Console in the package
`kbn/monaco` and will be worked on behind the config flag iteratively in
the next weeks.
To not let the dev config get into 8.13 release, this PR will only be
merged **after** 8.13 has been branched.
After this PR is merged, the team will start re-implementing existing
Console features in the new Monaco editor, see
elastic#176723 and
elastic#176926

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech
Copy link
Contributor Author

Closing in favor of #180207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants