Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BWC mode for saved_objects/_find endpoint required for all versions of 6.x #17685

Closed
spalger opened this issue Apr 12, 2018 · 2 comments
Closed
Assignees
Labels
blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.3.0

Comments

@spalger
Copy link
Contributor

spalger commented Apr 12, 2018

With #17512, which was backported to 6.3, we removed the GET /api/saved_objects/{type?} endpoint and replaced it with GET /api/saved_objects/_find. This is a breaking change that will cause incompatibility between clients and servers in the process of upgrading to 6.3 or beyond. To prevent from breaking clients during the transition we need to continue supporting the GET /api/saved_objects/{type?} API until 7.0.

@spalger spalger added blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.3.0 labels Apr 12, 2018
@spalger spalger self-assigned this Apr 12, 2018
@epixa
Copy link
Contributor

epixa commented Apr 12, 2018

These saved object APIs are experimental, so if it is really important that we break them, we can. The only API we need to be extremely careful with is the import API.

That said, breaking APIs just because we can isn't really a great practice in any case. If it's possible to introduce some sort of fallback mechanism or something in 6.x for the old behavior, that certainly would be ideal.

@spalger
Copy link
Contributor Author

spalger commented Apr 12, 2018

After discussing this a bit further we realized that Kibana clients that are from an old version of Kibana will not be able to use any APIs because of the version checks that the Kibana server does, so this isn't actually an issue.

@spalger spalger closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.3.0
Projects
None yet
Development

No branches or pull requests

2 participants