Rename saved objects bulk_get and find endpoints #17512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
💔 Build Failed |
spalger
force-pushed
the
rename/saved-objects/bulk-get-and-find
branch
from
a4155e4
to
b064cb1
Compare
💚 Build Succeeded |
kimjoar
approved these changes
Apr 4, 2018
| @@ -21,11 +18,6 @@ export const createFindRoute = (prereqs) => ({ | |||
| }, | |||
| handler(request, reply) { | |||
| const options = keysToCamelCaseShallow(request.query); | |||
|
|
|||
| if (request.params.type) { | |||
There was a problem hiding this comment.
I ❤️ that we're getting rid of this
…objects/bulk-get-and-find
💔 Build Failed |
…objects/bulk-get-and-find
💚 Build Succeeded |
…objects/bulk-get-and-find
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Apr 10, 2018
spalger
added a commit
that referenced
this pull request
Apr 11, 2018
|
6.3/6.x: 079f303 |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17510
Pairs with #17511
With #17510 we will be adding
POSTsupport to the find endpoint for saved objects, which means we need to disambiguate aPOSTto find from aPOSTto create an object without an id. To accomplish that this PR renames the find endpoint toGET /api/saved_objects/_findand only supports sending thetypeas a query string parameter.GET /api/saved_objectsis nowGET /api/saved_objects/_findGET /api/saved_objects/visualizationis nowGET /api/saved_objects/_find?type=visualizationWhile I'm in here I also updated the
bulk_getAPI to be/api/saved_objects/_bulk_get.release note:
In order to support sending larger and more expressive queries to the Saved Objects find API we will be adding a
POSTendpoint for find and therefore need a way to disambiguate the find API from from thePOSTAPI used to create Saved Objects. Starting in Kibana 6.3 endpoints that are not simple CRUD operations on a single object will be named and their name will start with an underscore, like in Elasticsearch: "GET /api/saved_objects" is now "GET /api/saved_objects/_find", "GET /api/saved_objects/{type}" is now "GET /api/saved_objects/_find?type={type}", and "GET /api/saved_objects/bulk_get" is now "GET /api/saved_objects/_bulk_get"