Vega and Timelion visualizations losing filter on save

[stacey-gammon]

This is found in v6.3

Seems like it might be specific to the filter I selected. There is an exception in the console but it was from earlier.

cc @elastic/kibana-discovery @elastic/kibana-visualizations

[stacey-gammon]

cc @nyurik - same thing seems to happen with vega. Not sure if it's the same bug or different

[lukasolson]

I'll try to take a look later today

[lukasolson]

Doesn't appear to be an issue with the filter bar/query bar itself. Seems that for some reason these viz types don't store the query/filters for some reason. @elastic/kibana-visualizations Any ideas?

[ppisljar]

maybe #17713 will solve this ?

[timroes]

#17713 won't fix that.

That's an issue with those visualizations bypass courier and SearchSource. Both visualization types (and TSVB) have a horrible and buggy way of reading out filters and query (at least if it's Lucene - as mentioned in #17722).

Storing filters and queries is implemented for search source automatically. Any visualization that doesn't use them is required to implement saving filters and queries itself. Since non implemented it, they should not show the filter and query bar in the editor (as TSVB does). That way the user at least doesn't have THAT weird behavior. They still have super weird behavior regarding pinned filters (see #17025).

The short term solution for this will be: fallback to the not ideal solution we have for TSVB and hiding the filter/query bar for Vega and Timelion (will open a PR for that). For actually proper building a solution one of two things would be required:

• No visualization should bypass SearchSource anymore. Maybe we will even make this a requirement for getting out of experimental mode. That way the whole way Kibana is currently build will still work for that.
• Quickly find a plan for unify the way global context is passed down to visualize #16641 to pass filters and queries down explicitly and do some more refactoring: if we pass down filters/queries explicitly to the request handlers and we would get rid of that dashboard_context but instead use the explicitly passed filters/queries, we could refactor the editor to always store the filters/queries on the saved object and merge them into the explicitly passed filters/queries, currently that only works with search source. We should really start discussing that very soon, since the issues and talks in just the past few days have showed me again, how broken that is. cc @spalger to be aware that we will need to discuss that very soon :)

[timroes]

I've opened #17735 for review, that solves it the way we have it for TSVB (and actually also had it at least in 5.6 for timelion).

[timroes]

I will remove the blocker label, since we have hidden the filter/query bar again via #17735, but we should still figure out the proper way for storing filters/queries with this via the approaches in #16641

[stratoula]

Not valid anymore