Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide filter/query bar for unsupported vis types #17735

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Apr 17, 2018

This PR hides the filter/query bar for timelion and Vega again (this got lost somewhere between 5.6 and now), since they are not properly able to store them - see #17719 for the longer discussion.

@timroes timroes added bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.0.0 v6.3.0 Feature:Vega Vega visualizations labels Apr 17, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes timroes merged commit 9e34253 into elastic:master Apr 17, 2018
@timroes timroes deleted the hide-filters branch April 17, 2018 12:57
timroes added a commit to timroes/kibana that referenced this pull request Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization Feature:Vega Vega visualizations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.3.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants