Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric threshold][Alert details page] Apply group information on the condition charts #178998

Closed
maryam-saeidi opened this issue Mar 19, 2024 · 1 comment · Fixed by #181689
Closed
Assignees
Labels
Feature:Alert Details Page Observability ux management team Feature:Alerting Team:obs-ux-management Observability Management User Experience Team v8.15.0

Comments

@maryam-saeidi
Copy link
Member

📝 Summary

At the moment, if the metric threshold has a grouping, preview charts show the first group's information. We need to change this behavior for the alert details page to show the information related to the alert group. For this, we need to adjust the preview chart to accept group information and filter data accordingly.

image

✅ Acceptance Criteria

  • Show the correct group information on the alert details page
@maryam-saeidi maryam-saeidi added Feature:Alert Details Page Observability ux management team Team:obs-ux-management Observability Management User Experience Team labels Mar 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi self-assigned this Apr 22, 2024
maryam-saeidi added a commit that referenced this issue May 16, 2024
…lert details page (#181689)

Resolves #178998

## Summary

This PR
- Persists group by information and apply it in the alert details page
- Adds source and tags to the alert summary field
- Fixes annotation issue on the chart by adding a margin-top

**Note**
I showed the chart title temporarily in the screenshots below for
verification: (You can do the same by removing hideTitle)
| State | Screenshot |
|---|---|
|Before|<img
src="https://github.com/elastic/kibana/assets/12370520/46d39e04-f871-476f-b06b-66e7eb77db5d"
width=700 /><img
src="https://github.com/elastic/kibana/assets/12370520/243ea2aa-8542-4a1f-91ff-d47c01b8452b"
width=700 />|
|After|<img
src="https://github.com/elastic/kibana/assets/12370520/3b632d4f-690f-4a2f-90d6-3b9ec3d14e39"
width=700 />|

### How to test
- Create a metric threshold rule 
    - make sure to enable the related feature flag
     ```
     xpack.observability.unsafe.alertDetails.observability.enabled: true
     ```
- Go to the alert details page and verify the charts show data related
to the selected group
   - either remove hideTitle
- or make sure the data in the chart matches expectations for that
specific group
   - or check the `metrics_explorer`
   
<img
src="https://github.com/elastic/kibana/assets/12370520/20996859-0e17-44fa-a294-0c124daf849e"
width=500 />
<img
src="https://github.com/elastic/kibana/assets/12370520/21beda58-0aff-42c2-a74e-df422eda347c"
width=500 />

- Create an APM Latency threshold rule and check the active alert
annotation to have the right color.

![image](https://github.com/elastic/kibana/assets/12370520/dd14cf99-e44e-4531-a221-7ed40bb43c5a)

---------

Co-authored-by: Faisal Kanout <faisal@kanout.com>
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alert Details Page Observability ux management team Feature:Alerting Team:obs-ux-management Observability Management User Experience Team v8.15.0
Projects
None yet
3 participants