Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB custom CSS broken in v8.13.0 #179498

Closed
patodevilla opened this issue Mar 26, 2024 · 8 comments
Closed

TSVB custom CSS broken in v8.13.0 #179498

patodevilla opened this issue Mar 26, 2024 · 8 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) regression Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@patodevilla
Copy link

Kibana version: 8.13.0

Elasticsearch version: 8.13.0

Server OS version:

Browser version: Version 123.0.6312.59 (Official Build) (arm64)

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.): download page

Describe the bug: In a TSVB visualization custom CSS styling appears to be ignored.

Steps to reproduce:

  1. Create a TSVB
  2. Add some text in Markdown tab
  3. Add any css in Panel options tab.

example css:

* {
  background-color: red;
}

Expected behavior: In a TSVB visualization, css added in Panel options tab should be applied

Screenshots (if relevant):

version 8.12.x

Screenshot 2024-03-26 at 4 45 47 PM

version 8.13.0

Screenshot 2024-03-26 at 4 47 04 PM

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@patodevilla patodevilla added the bug Fixes for quality problems that affect the customer experience label Mar 26, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 26, 2024
@dej611 dej611 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 27, 2024
@markov00
Copy link
Member

Checked and it doesn't apply the CSS.

The relative code is here

// wrapping select for markdown body to make sure selector specificity wins over base styles
css(`.kbnMarkdown__body {
${model.markdown_css}
}`)

Looking at the dev tools seems that the CSS is processed, a new emotion class is created and applied on the fly to the markdown body but or the class is wrongly generated and is completely empty or is just not attached to the dom.

@markov00
Copy link
Member

hey @elastic/appex-sharedux team I believe this could be caused by this PR #176478
The the CSS is applied to the div container but probably to the change in the markdown component it is not anymore pickedup.

@markov00 markov00 added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Mar 28, 2024
@petrklapka
Copy link
Member

@eokoneyo - Another possible regression of the new markdown component?

@stratoula
Copy link
Contributor

@petrklapka yes it seems is the same cause as the other markdown bug.

@eokoneyo
Copy link
Contributor

eokoneyo commented Apr 2, 2024

@eokoneyo - Another possible regression of the new markdown component?

Yes... it's related to the new markdown component

@eokoneyo
Copy link
Contributor

eokoneyo commented Apr 3, 2024

A fix has been made for this issue, it's not very clear how the new markdown caused this issue. I have documented what happens that results in this issue in the PR linked above.

@eokoneyo
Copy link
Contributor

eokoneyo commented Apr 8, 2024

The change that resulted in this issue has been reverted for an expedited resolution here and will be available in the next patch release

@eokoneyo eokoneyo closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) regression Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants