Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Document flyout table search bar keyboard navigation & selection unavailable #180008

Closed
spong opened this issue Apr 4, 2024 · 2 comments · Fixed by #180022
Closed
Assignees
Labels
accessibility: keyboard navigation Accessibility keyboard navigation and focus bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects

Comments

@spong
Copy link
Member

spong commented Apr 4, 2024

In Kibana main/8.14.0, keyboard navigation and selection are unavailable in the table search text box within the document flyout. The default text box behavior appears to be captured by the document navigation keyboard shortcuts, as you can see by the different documents being selected instead of the cursor moving or selecting text as shown below.

Expected behavior here is that when the search text box has focus, the default text box keyboard navigation and selection behaviors are present. Confirmed reproducible in Arc/Chrome.

@spong spong added the bug Fixes for quality problems that affect the customer experience label Apr 4, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 4, 2024
@spong spong added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) accessibility: keyboard navigation Accessibility keyboard navigation and focus labels Apr 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 4, 2024
@kibanamachine kibanamachine added this to Inbox in Discover Apr 4, 2024
@jughosta jughosta self-assigned this Apr 4, 2024
@jughosta
Copy link
Contributor

jughosta commented Apr 4, 2024

@spong Thanks for reporting!

jughosta added a commit that referenced this issue Apr 5, 2024
- Closes #180008

## Summary

This PR fixes keyboard events in DocViewer flyout. Now when the search
input is in focus, it would not trigger navigation between docs.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 5, 2024
…0022)

- Closes elastic#180008

## Summary

This PR fixes keyboard events in DocViewer flyout. Now when the search
input is in focus, it would not trigger navigation between docs.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit 568b0f4)
kibanamachine added a commit that referenced this issue Apr 5, 2024
…0022) (#180129)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Discover][DocViewer] Fix keyboard events in search input
(#180022)](#180022)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-04-05T10:18:37Z","message":"[Discover][DocViewer]
Fix keyboard events in search input (#180022)\n\n- Closes
#180008
Summary\r\n\r\nThis PR fixes keyboard events in DocViewer flyout. Now
when the search\r\ninput is in focus, it would not trigger navigation
between docs.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"568b0f4806d2f6a64a0126d92d52b46d3c783ce2","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","Feature:UnifiedDocViewer","v8.14.0"],"title":"[Discover][DocViewer]
Fix keyboard events in search
input","number":180022,"url":"#180022
Fix keyboard events in search input (#180022)\n\n- Closes
#180008
Summary\r\n\r\nThis PR fixes keyboard events in DocViewer flyout. Now
when the search\r\ninput is in focus, it would not trigger navigation
between docs.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"568b0f4806d2f6a64a0126d92d52b46d3c783ce2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180022","number":180022,"mergeCommit":{"message":"[Discover][DocViewer]
Fix keyboard events in search input (#180022)\n\n- Closes
#180008
Summary\r\n\r\nThis PR fixes keyboard events in DocViewer flyout. Now
when the search\r\ninput is in focus, it would not trigger navigation
between docs.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"568b0f4806d2f6a64a0126d92d52b46d3c783ce2"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility: keyboard navigation Accessibility keyboard navigation and focus bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants