Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors about "Encrypted Saved Objects plugin is missing encryption key" are marked as user errors #180418

Closed
mikecote opened this issue Apr 9, 2024 · 2 comments · Fixed by #184424
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Apr 9, 2024

I noticed in the actions plugin whenever an error of Unable to execute action because the Encrypted Saved Objects plugin is missing encryption key. Please set xpack.encryptedSavedObjects.encryptionKey in the kibana.yml or use the bin/kibana-encryption-keys command. is thrown, we mark it as a user error (link to code).

Given in serverless we control the encryption key, we should be the ones aware and notified if ever the field is missing.

cc @elastic/response-ops-execution @kobelb @heespi

@mikecote mikecote added the bug Fixes for quality problems that affect the customer experience label Apr 9, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 9, 2024
@bhavyarm bhavyarm added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Apr 10, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 10, 2024
@kobelb
Copy link
Contributor

kobelb commented Apr 10, 2024

Great catch, @mikecote. In ESS dedicated, this would be the same also, right? For on-prem, it's the only situation where we don't know if we broke something with the AAD or the customer changed the encryption key?

@mikecote
Copy link
Contributor Author

mikecote commented Apr 10, 2024

@kobelb

In ESS dedicated, this would be the same also, right?

Correct, given we are in control of these encryption keys.

For on-prem, it's the only situation where we don't know if we broke something with the AAD or the customer changed the encryption key?

From following the code path down to the ESO plugin (link), this error will only occurs if an encryption key hasn't been set in the kibana.yml file. This will be good to indicate to on-prem system admins that something is wrong.

This part of the code doesn't capture errors caused by breaking something with the AAD, the AAD errors are reported as "framework" errors here (link) unless it's a 404, which would be caused by the user / test deleting the rule while it's running.

@doakalexi doakalexi assigned doakalexi and unassigned doakalexi May 1, 2024
@ersin-erdal ersin-erdal self-assigned this May 29, 2024
ersin-erdal added a commit that referenced this issue May 30, 2024
Resolves: #180418

This PR marks `Encrypted Saved Objects plugin is missing encryption key`
errors as framework error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants