Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] The indices list is called every time I write something in the editor #180588

Closed
stratoula opened this issue Apr 11, 2024 · 3 comments
Closed

[ES|QL] The indices list is called every time I write something in the editor #180588

stratoula opened this issue Apr 11, 2024 · 3 comments
Assignees
@stratoula
Labels
Feature:ES|QL impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. performance Team:ESQL ES|QL related features in Kibana

Comments

@stratoula
Copy link
Contributor

Every time I write something in the editor there is a call in the dataviews.getIndices call. It should not happen

meow

Ideally, we should get the indices only in the from command or we should at least cache the results and not make this call every time. Not sure how it affects the performance but I don't like it.
@stratoula stratoula added performance impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Apr 11, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 11, 2024
@stratoula stratoula added Feature:ES|QL Team:ESQL ES|QL related features in Kibana and removed needs-team Issues missing a team label labels Apr 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon
Copy link
Contributor

Good catch

@stratoula stratoula mentioned this issue Apr 29, 2024
Closed
@stratoula stratoula mentioned this issue May 21, 2024
Merged
@stratoula stratoula self-assigned this May 21, 2024
stratoula added a commit that referenced this issue May 23, 2024
@stratoula
[ES|QL] Improve editor's performance by caching the data sources (#18…
7378d56 
…3886)

## Summary

Part of #180588

Caching the sources in the editor in order to not retrieve them every
time a user is typing something. This is an important performance boost
for the editor.

There are more things wrong, for example we are always fetching the
metadata. I think this is wrong, the metadata is and will always be a
static list. This should be cleaned up in a follow up PR
@stratoula
Copy link
Contributor Author

Closed by #183886

rshen91 pushed a commit to rshen91/kibana that referenced this issue May 30, 2024
@stratoula @rshen91
[ES|QL] Improve editor's performance by caching the data sources (ela…
4875e71 
…stic#183886)

## Summary

Part of elastic#180588

Caching the sources in the editor in order to not retrieve them every
time a user is typing something. This is an important performance boost
for the editor.

There are more things wrong, for example we are always fetching the
metadata. I think this is wrong, the metadata is and will always be a
static list. This should be cleaned up in a follow up PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
Feature:ES|QL impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. performance Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drewdaemon @elasticmachine @stratoula