-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneDiscover] Implement improved switching between ES|QL and DataView mode experience #182083
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Pinging @elastic/kibana-esql (Team:ESQL) |
This is not a super small change. Right now the logic to change from ES|QL to DSL and vice versa is on the unified search plugin. With this change we need to move the ES|QL selection to Discover and the logic to go from ES\QL to KQL to the ES|QL editor. I don’t think it will be super tricky but it def makes it a bigger task. I am highlighting this because at a first glance it might seem as a super small task but it is not |
Yes, it's not a small one, additionally, also the switch to ESQL seems to be displayed differently depending on serverless and stateful, which is another layer of complexity |
yes I was hoping to convince people to have one mode and not two but this is a very good point @kertal 😄 |
@stratoula I would also appreciate this! Less modes, less complexity, less confusion, easier to implement, something looks like a small thing, but sadly it ain't the case |
++ to preferring a single way for both stateful and serverless if possible. |
Synced with @ryankeairns offline and we agreed on going with the same design on both products 👍 |
Added design notes and link to prototype in description. |
Increase the discoverability of ES|QL in Discover with a leaning toward ES|QL over KQL.
Design notes
Pending stakeholder view → Figma prototype
The text was updated successfully, but these errors were encountered: