Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneDiscover] Implement improved switching between ES|QL and DataView mode experience #182083

Open
Tracked by #181576
kertal opened this issue Apr 30, 2024 · 9 comments
Open
Tracked by #181576
Labels
enhancement New value added to drive a business result Feature:ES|QL Project:OneDiscover Enrich Discover with contextual awareness / Merge with Logs Explorer Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:ESQL ES|QL related features in Kibana
Projects

Comments

@kertal
Copy link
Member

kertal commented Apr 30, 2024

Increase the discoverability of ES|QL in Discover with a leaning toward ES|QL over KQL.

Design notes

Pending stakeholder view → Figma prototype

  • More visual weight going to ES|QL; less going from ES|QL to KQL
  • For the button in the footer of the editor, we intentionally show ES|QL (as opposed to 'switch to KQL' or 'KQL')
  • Not depicted in the prototype, keep the green 'Try ES|QL' button in the data view menu; else, any other users of Unified Search (who relay on this button) would have to implement a separate button in their app menu, as well. In Discover, you would see both - the green button and a button in the app menu (depicted in prototype)
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 30, 2024
@kertal kertal added the Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) label Apr 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 30, 2024
@kertal kertal added needs-team Issues missing a team label Project:OneDiscover Enrich Discover with contextual awareness / Merge with Logs Explorer labels Apr 30, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 30, 2024
@kibanamachine kibanamachine added this to Inbox in Discover Apr 30, 2024
@kertal kertal changed the title [Discover] Implement improved switching between ES|QL and DataView mode experience [OneDiscover] Implement improved switching between ES|QL and DataView mode experience Apr 30, 2024
@kertal kertal added the enhancement New value added to drive a business result label May 2, 2024
@stratoula stratoula added Feature:ES|QL Team:ESQL ES|QL related features in Kibana labels May 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula
Copy link
Contributor

Here is the proposal
image

CleanShot 2024-05-10 at 07 31 01@2x

This is not a super small change. Right now the logic to change from ES|QL to DSL and vice versa is on the unified search plugin. With this change we need to move the ES|QL selection to Discover and the logic to go from ES\QL to KQL to the ES|QL editor. I don’t think it will be super tricky but it def makes it a bigger task. I am highlighting this because at a first glance it might seem as a super small task but it is not

@kertal
Copy link
Member Author

kertal commented May 13, 2024

Yes, it's not a small one, additionally, also the switch to ESQL seems to be displayed differently depending on serverless and stateful, which is another layer of complexity

@stratoula
Copy link
Contributor

yes I was hoping to convince people to have one mode and not two but this is a very good point @kertal 😄

@kertal
Copy link
Member Author

kertal commented May 13, 2024

@stratoula I would also appreciate this! Less modes, less complexity, less confusion, easier to implement, something looks like a small thing, but sadly it ain't the case

@davismcphee
Copy link
Contributor

++ to preferring a single way for both stateful and serverless if possible.

@stratoula
Copy link
Contributor

Synced with @ryankeairns offline and we agreed on going with the same design on both products 👍

@ryankeairns
Copy link
Contributor

Added design notes and link to prototype in description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ES|QL Project:OneDiscover Enrich Discover with contextual awareness / Merge with Logs Explorer Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:ESQL ES|QL related features in Kibana
Projects
No open projects
Development

No branches or pull requests

5 participants