-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Increase discoverability of ES|QL (aka switcher) #184691
Comments
Pinging @elastic/kibana-esql (Team:ESQL) |
@ryankeairns this is cool but I dont understand how it will look in Discover that has already the time picker and the Run button in the navigation 🤔 . Can you please share a screenshot on this integrated in various places such as Discover or inline editing of an ES|QL chart? Update: I guess it will look like this? |
@ryankeairns which is the difference from this issue #182083 I am trying to keep our backlog clean and I dont want to have duplicated content but if you feel that we need both is also ok. 👍 |
Ah yes, that one was specific to just the switching mechanism even though it shows the other editor changes. I'll convert this issue to a meta, break it down into workable chunks, and create a small set of issues (e.g. fixes, moving buttons around, adding the switcher). This way, it will become more clear what can be worked on now (fixes) and if/when the other items are approved. Sound good @stratoula ? |
Sounds fantastic! |
Right, like that. I will add that since writing up this issue, I have put together some additional ideas that utilize the existing bar/space above the editor (spoiler alert: it has to do with controls). We will review them tomorrow during our sync! |
## Summary Part of #184691 ```[tasklist] ### Things addressed - [x] Fix double bottom border on header - [x] Fix missing bottom border on footer/editor - [x] Reduce left and right padding on header to 4px - [x] Consolidate _Add/remove line breaks on pipes_ to a single icon (toggle between) - [x] Fix 1px gap above editor footer - [x] Changed the icon of the history component ```
@stratoula hold off on this one, please. I want to review some new designs with you/the team before we proceed. I have some things in mind for the possibility of controls and search that could leverage the space in the top bar. |
So we are not moving the time picker and run button in the editor but we are filling the gap with controls? Yes, I would love to discuss it in person 👍 |
@stratoula I went ahead and split the two new additions to the info bar (aka footer) into separate issues |
This meta issue provides an overview of the next version of the ES|QL editor. It coincides with a new "switcher" button that will draw more users into using ES|QL.
Design <> Development handoff
→ Annotated Figma file
→ Prototype showing switching interaction
Proposed end state
1. Add new 'Try ES|QL' button in current default mode
(see next image)
2. Make the data view picker more clearly about data views
...and remove the current 'Language: ES|QL' button from the data view picker
![](https://private-user-images.githubusercontent.com/446285/351454637-82ced669-ce8b-4359-b448-7cf7bc8e855d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2MDg1OTUsIm5iZiI6MTcyMzYwODI5NSwicGF0aCI6Ii80NDYyODUvMzUxNDU0NjM3LTgyY2VkNjY5LWNlOGItNDM1OS1iNDQ4LTdjZjdiYzhlODU1ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgxNFQwNDA0NTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kY2JmZDliYjVmMGMwMTFkNWM2ZmI2Y2VkNzM5OTQzZjI5NjE4N2E3ZWFiNzJkNmY0YzVhMzBlMzMzYzE3YjUxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.qkAe5B5_WWYBrDgrtX2Mu7iiWhzV27YEKH6Z1wDWWDU)
3. Drop compressed editor
4. Make the expanded editor more editor-like
5. Introduce V1 of new 'file menu'
https://www.elastic.co/guide/en/elasticsearch/reference/8.13/esql.html
?What else will be in this menu?
Next up will likely be New and Save capabilities.
Over time, several other items could be added as demonstrated below (for example only; not to be taken too literally)
TODOs
Switcher + editor changes #182083
Related enhancements for informational purposes
The text was updated successfully, but these errors were encountered: