Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Alerts] Filters sorting not working properly for some cases #182961

Closed
alexwizp opened this issue May 8, 2024 · 6 comments
Closed

[Security Solution][Alerts] Filters sorting not working properly for some cases #182961

alexwizp opened this issue May 8, 2024 · 6 comments
Assignees
@logeekal
Labels
bug Fixes for quality problems that affect the customer experience notabug When the issue is closed this label Indicates that it wasn't a bug Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@alexwizp
Copy link
Contributor

alexwizp commented May 8, 2024

Description:

[Security Solution][Alerts] Sorting of filters not functioning correctly in certain cases.

Steps to reproduce:

  1. Open Serverless Security instance.
  2. Navigate to Alerts.
  3. Switch to Edit Control mode in the Filters area.
image
  1. Utilize Drag and Drop to move the last filter to the first position.
  2. Click on the Save button.

Expected behavior: Sorting changes should be saved.
Actual result: Sorting changes are not saved.

#Screen:

Screen.Recording.2024-05-08.at.17.57.23.mov
@alexwizp alexwizp added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels May 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@alexwizp alexwizp mentioned this issue May 8, 2024
Merged
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels May 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti
Copy link
Contributor

@alexwizp thanks for opening this bug! I tested this and I can indeed reproduce the issue. It seems that I can reorder things just fine except when I'm trying to put any filter to the left of the Status filter... It's like Status always has to be first...

@logeekal any idea what could be causing this?

alexwizp added a commit that referenced this issue May 8, 2024
@alexwizp
Update the versions of @dnd-kit/* libs (#182955)
233cc1e 
Closes: elastic/security-team#8630

## Summary

The new version of the library implements broader support for
accessibility (a11y) and fixes the issue described in
elastic/security-team#8630. **This library is
only used in one place in Kibana.**


### What was changed?:

1. Versions updated: 

|Lib | From | To |
|--| -- | -- |
`@dnd-kit/core`| `^3.1.1`, |  `^6.1.0`,
`@dnd-kit/sortable`| `^4.0.0`-|`^8.0.0`
`@dnd-kit/utilities`| `^2.0.0`, | `^3.2.2`


2.    The following core was replaced in accordance with the changelog
```
layoutMeasuring={{
  strategy: LayoutMeasuringStrategy.Always,
}} 
```
-> 
```
 measuring={{
    droppable: {
      strategy: MeasuringStrategy.Always,
    },
  }}
```

## Notes

During testing, an unrelated issue was discovered:
#182961.
@logeekal
Copy link
Contributor

Hey @alexwizp , It is by design that Status filters will always remain the first drop down. You can always reorder the other filters without any issues.

The reason Status remains on first position is because any value that you choose in First filter will be cascaded to the further filters. For example, if you have Status = Open then you will see Severity , Host & User that assigned only in the Open alerts. And Elastic thinks that Status of the alert has the highest priority.

In the future, we will try to disable Drag-n-Drop on Status so that you can reorder only other filters. But currently, it is not possible.

Please let me know if there are any further questions.

@logeekal logeekal added the notabug When the issue is closed this label Indicates that it wasn't a bug label May 14, 2024
@alexwizp
Copy link
Contributor Author

@logeekal thanks, closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logeekal logeekal

Labels
bug Fixes for quality problems that affect the customer experience notabug When the issue is closed this label Indicates that it wasn't a bug Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@logeekal @elasticmachine @PhilippeOberti @MadameSheema @alexwizp