Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert details page][Metric threshold] Deprecate feature flag #183489

Closed
4 tasks done
maryam-saeidi opened this issue May 15, 2024 · 1 comment · Fixed by #186623
Closed
4 tasks done

[Alert details page][Metric threshold] Deprecate feature flag #183489

maryam-saeidi opened this issue May 15, 2024 · 1 comment · Fixed by #186623
Assignees
@maryam-saeidi
Labels
Feature:Alert Details Page Observability ux management team Team:obs-ux-management Observability Management User Experience Team v8.15.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented May 15, 2024 •
edited
Loading

🍒 Summary

When the metric threshold rule is ready, we need to deprecate the related feature flag, similar to what has been done for the custom threshold rule here.

xpack.observability.unsafe.alertDetails.metrics.enabled: true

TODO

Nice to have

🎯 Acceptance Criteria

  • Deprecate the related feature flag and ensure that nothing is broken even if the flag is provided in the config.
  • Remove the Technical Preview badge.
@maryam-saeidi maryam-saeidi added Feature:Alert Details Page Observability ux management team Team:obs-ux-management Observability Management User Experience Team labels May 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi mentioned this issue May 15, 2024
Merged
@maryam-saeidi maryam-saeidi self-assigned this May 29, 2024
@maryam-saeidi maryam-saeidi mentioned this issue Jun 21, 2024
Merged
maryam-saeidi added a commit that referenced this issue Jun 24, 2024
@maryam-saeidi
[Metric threshold] Deprecate unsafe.alertDetails.metrics.enabled feat…
626f2b1 
…ure flag (#186623)

Fixes #183489

It also removes the technical preview badge from the metric threshold
alert details page.

Having this feature flag now gives you the following warning and even
changing it to false will not have any impact:
```
[2024-06-21T17:09:01.688+02:00][WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.alertDetails.metrics.enabled".
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Feature:Alert Details Page Observability ux management team Team:obs-ux-management Observability Management User Experience Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Metric threshold] Deprecate unsafe.alertDetails.metrics.enabled feature flag maryam-saeidi/kibana
2 participants
@maryam-saeidi @elasticmachine