-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Improve initial empty state #183971
Comments
Pinging @elastic/kibana-esql (Team:ESQL) |
@ryankeairns also it would be nice to think how an empty state will look in discover. Currently if the user submits an empty query we error out (as we are sending the request at ES and query is a mandatory field) ![]() Ideas:
|
## Summary Part of #183971 This PR suppresses the errors in the editor when the query is empty. It also sets the editor in a read only state when the query is not set and the user hasn't focused. Read only means that the validation won't run. At the point the user focuses on the editor, the validation will start running again. ![meow](https://github.com/elastic/kibana/assets/17003240/636a9d12-6b0e-4533-8f6a-d63664336178)![meow1](https://github.com/elastic/kibana/assets/17003240/911450a0-96bc-4627-9fff-bbdc8aadfa2a)
## Summary Part of elastic#183971 This PR suppresses the errors in the editor when the query is empty. It also sets the editor in a read only state when the query is not set and the user hasn't focused. Read only means that the validation won't run. At the point the user focuses on the editor, the validation will start running again. ![meow](https://github.com/elastic/kibana/assets/17003240/636a9d12-6b0e-4533-8f6a-d63664336178)![meow1](https://github.com/elastic/kibana/assets/17003240/911450a0-96bc-4627-9fff-bbdc8aadfa2a)
This has been partially been addressed. Now we don't error out on an empty query |
Closing this given the partial resolution. Will open a new issue once design is ready. |
Describe the feature:
Currently, an error message is present when the editor is empty. This means all new queries begin with an error warning.
Instead, we could suppress the error/validation check and, alternatively, show either placeholder text or an initial suggestion once the user enters (focuses) on the editor.
Describe a specific use case for the feature:
from
,row
, orshow
. Technically, they can type anything, but this seems the most common, logical starting point for a new query.The text was updated successfully, but these errors were encountered: