-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover][Extension] Document Viewer #184084
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@kertal I discussed this with @jughosta earlier, and I think we can start implementing this extension point now, but I think we should split this task out into a followup issue until we have a clear product need for it:
IMO in an ideal situation all Discover profiles would use the same base flyout and customize it as needed, otherwise I feel it will impact consistency and complicate the extension point, making the compositional aspect of the framework harder to manage for this extension point (e.g. can be customized at multiple context levels). If that works for you, can we switch this from |
Sure works for me, removed this task, added it as a draft to our board, I do agree we need more product details here. |
- Closes elastic#184084 ## Summary This PR adds extension points to Doc Viewer flyout: - `title` - `docViewsRegistry`. Example: ```typescript profile: { getDocViewer: (prev) => (params) => { const recordId = params.record.id; const prevValue = prev(params); return { title: `${prevValue.title} #${recordId}`, docViewsRegistry: (registry) => { registry.enableById('doc_view_logs_overview'); return prevValue.docViewsRegistry(registry); }, }; }, }, ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sorry I stumbled on this PR today so I am asking this question here itself for reference.
@davismcphee , as you mentioned here, is there a followup issue planned because of from Security side we would like to bring our own flyout to discover. And if it is not planned yet, how can we bring this up so that we can add this customization to the list? |
@logeekal I followed up a bit on this in Slack, but the best way to approach this would be to coordinate this request through our product teams, likely at the weekly One Discover sync so it can be discussed. |
馃摀 Summary
What: The extension point entails creating a custom fly-out interface within the document viewer. This could involve adding functionalities such as better navigation, filtering options, or additional contextual information to enhance the UX when viewing documents.
Why: This improvement is driven by a need to provide users with a contextual and efficient way to view and interact with specific document types.
This is the current, vanilla Document Viewer in Discover
This is the version being used by Log Explorer
The aim is to provide the extension point configuration that enables this extended version, optimized for logs usage, to be provided by the Contextual awareness architecture, and can be used to extend the Document Viewer for different contexts
鉁旓笍 Acceptance criteria
The text was updated successfully, but these errors were encountered: