Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert details page] [APM Latency] Unable to load page error #184204

Closed
benakansara opened this issue May 24, 2024 · 1 comment · Fixed by #184236
Closed

[Alert details page] [APM Latency] Unable to load page error #184204

benakansara opened this issue May 24, 2024 · 1 comment · Fixed by #184236
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team

Comments

@benakansara
Copy link
Contributor

APM latency threshold alert details page shows error. It seems to be related to the View in APM link introduced in #183415.

TypeError: Cannot read properties of undefined (reading 'url')
    at ViewInAPMButton 
Screenshot 2024-05-24 at 12 06 20 Screenshot 2024-05-24 at 12 04 35
@benakansara benakansara added bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team labels May 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

dominiqueclarke added a commit that referenced this issue May 26, 2024
## Summary

Resolves #184204

The page can break when the share plugin is undefined. This PR adds
defensive code to prevent errors when `share` is undefined.


![image](https://github.com/elastic/kibana/assets/11356435/538a73e1-e8b5-4743-8a01-f723695dcf86)


![image](https://github.com/elastic/kibana/assets/11356435/4a3a606e-4aa0-4aed-a644-83cdf3965dbd)


### Testing
Generate some mock APM data with ```node scripts/synthtrace.js
simple_trace --live```
Create an APM latency rule
Wait for the rule to be triggered, then navigate to the alert details
page
The alert details page should load properly
rshen91 pushed a commit to rshen91/kibana that referenced this issue May 30, 2024
## Summary

Resolves elastic#184204

The page can break when the share plugin is undefined. This PR adds
defensive code to prevent errors when `share` is undefined.


![image](https://github.com/elastic/kibana/assets/11356435/538a73e1-e8b5-4743-8a01-f723695dcf86)


![image](https://github.com/elastic/kibana/assets/11356435/4a3a606e-4aa0-4aed-a644-83cdf3965dbd)


### Testing
Generate some mock APM data with ```node scripts/synthtrace.js
simple_trace --live```
Create an APM latency rule
Wait for the rule to be triggered, then navigate to the alert details
page
The alert details page should load properly
dominiqueclarke added a commit that referenced this issue Jun 10, 2024
## Summary
Relates to #184204
Relates to #184236

After adding the `View in APM` buttons to APM alert details
visualizations, a bug was introduced where the share plugin was not
available in the codepath.

This was due to using the `useAPMPluginContext` hook. APM plugin context
does not exist within the observability plugin where this component is
rendered.

The use of `useAPMPluginContext` did work when using the visualization
embeddables, because they are wrapped in context, but when using the
visualizations on their own, such as in the APM latency alert details
page, the experience was broken.

To fix the experience, we added some defensive code and hid the button
when the `share` plugin was not available.

Now, we want to introduce a permenant fix to re-introduce the View in
APM button the APM alert details visualization. This fix uses
`useKibana` rather than `useAPMPluginContext` to gain access to the
`share` plugin.

SLO APM latency SLI alert details

![image](https://github.com/elastic/kibana/assets/11356435/86fa3c4d-c0aa-4cf6-a9f1-46b8174c36d1)

SLO APM error rate SLI alert details

![image](https://github.com/elastic/kibana/assets/11356435/a519606b-bb6f-49c5-9c91-733e5c466390)

APM latency alert details 

![image](https://github.com/elastic/kibana/assets/11356435/1c9f2037-869d-4a57-836b-63c430ca9ee5)


### Testing

Both the APM SLO burn rate rules and the APM latency rules should be
tested in this PR

1. Generate APM test data. For example, you can use `node
scripts/synthtrace simple_trace --live`
2. Create an APM latency rule with the threshold that will trigger an
alert
3. Navigate to the alert details page
4. Ensure the page loads and the `View in APM` button appears
5. Click on the View in APM button to ensure it navigates to APM
appropriately
6. Create an APM latency SLI within the SLO app. Choose a threshold that
will trigger a low SLI value
7. Wait for a burn rate alert to fire (the rule is created
automatically)
8. Navigate to the alert details page. Ensure the page loads and the
`View in APM` button appears
9. Click on the View in APM button to ensure it navigates to APM
appropriately
10. Repeat steps 6 to 9 with the APM error rate SLI within the SLO app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants