Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM][Serverless] Add test coverage for service_map and critical_path endpoints #186450

Closed
crespocarlos opened this issue Jun 19, 2024 · 1 comment · Fixed by #186466
Closed

[APM][Serverless] Add test coverage for service_map and critical_path endpoints #186450

crespocarlos opened this issue Jun 19, 2024 · 1 comment · Fixed by #186466
Assignees
@crespocarlos
Labels
apm:service-maps Service Map feature in APM apm:trace-explorer APM UI Trace Explorer Work Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@crespocarlos
Copy link
Contributor

Summary

Following up on the work done in PR #109444, which introduces a configuration that restricts scripted metrics aggregations to those listed in the configuration file, we need to add tests in the serverless suite to cover the service_map and critical_path endpoints. This will ensure the serverless configuration is always synchronized with the actual queries.

Context: The Elasticsearch config will look similar this. Essentially, the scripted metric from Kibana needs to be copied into an elasticsearch serverless configuration file (TBD where exactly).

Acceptance Criteria

  • both service_map and critical_path have tests that validate at least if the endpoints respond with 200.
@crespocarlos crespocarlos added apm:service-maps Service Map feature in APM apm:trace-explorer APM UI Trace Explorer Work labels Jun 19, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 19, 2024
@crespocarlos crespocarlos added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jun 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 19, 2024
@crespocarlos crespocarlos self-assigned this Jun 19, 2024
@crespocarlos crespocarlos mentioned this issue Jun 19, 2024
Merged
crespocarlos added a commit that referenced this issue Jun 20, 2024
@crespocarlos @kibanamachine
[APM] Add tests for service_map and critical_path endpoints to server…
4db61fa 
…less integration tests suite (#186466)

closes [186450](#186450)

## Summary

Add tests for aggregate critical path and service map endpoints to
serverless test suite

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
bhapas pushed a commit to bhapas/kibana that referenced this issue Jun 24, 2024
@crespocarlos @kibanamachine @bhapas
[APM] Add tests for service_map and critical_path endpoints to server…
f9e3762 
…less integration tests suite (elastic#186466)

closes [186450](elastic#186450)

## Summary

Add tests for aggregate critical path and service map endpoints to
serverless test suite

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crespocarlos crespocarlos

Labels
apm:service-maps Service Map feature in APM apm:trace-explorer APM UI Trace Explorer Work Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
2 participants
@crespocarlos @elasticmachine