-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console Monaco migration] Fixes #186479
[Console Monaco migration] Fixes #186479
Conversation
/ci |
Pinging @elastic/kibana-management (Team:Kibana Management) |
@@ -948,8 +948,6 @@ describe('Integration', () => { | |||
autoCompleteSet: [ | |||
tt('field1.1.1', { f: 1 }, 'string'), | |||
tt('field1.1.2', { f: 1 }, 'string'), | |||
tt('field2.1.1', { f: 1 }, 'string'), | |||
tt('field2.1.2', { f: 1 }, 'string'), | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes in this test files is the reverse of changes in this PR #162917
@@ -133,12 +133,12 @@ describe('Knowledge base', () => { | |||
); | |||
|
|||
indexTest('Index integration 2', ['index1'], [], { | |||
index: ['index1'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes in this test files is the reverse of changes in this PR #162917
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these fixes @yuliacech! Tested locally and the behavior in the described cases is correct. Code changes also LGTM.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Fixes #184927
Fixes #184584
Fixes #184447
This PR fixes various issues in the migrated Console:
How to test
GET _search?q="test test"
. The request should be executed correctly.Try a search query with the fields autocomplete and check that only 1 field is suggested
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers