[Console] Fix index fields autocomplete

elastic · Jun 19, 2024 · 316e9a4 · 316e9a4
1 parent 9352437
commit 316e9a4
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 1 deletion.
diff --git a/src/plugins/console/public/lib/autocomplete/components/index_autocomplete_component.js b/src/plugins/console/public/lib/autocomplete/components/index_autocomplete_component.js
@@ -24,4 +24,12 @@ export class IndexAutocompleteComponent extends ListComponent {
     }
     return !_.find(tokens, nonValidIndexType);
   }
+
+  getDefaultTermMeta() {
+    return 'index';
+  }
+
+  getContextKey() {
+    return 'indices';
+  }
 }
diff --git a/test/functional/apps/console/monaco/_autocomplete.ts b/test/functional/apps/console/monaco/_autocomplete.ts
@@ -370,5 +370,31 @@ GET _search
         });
       });
     });
+
+    describe('index fields autocomplete', () => {
+      const indexName = `index_field_test-${Date.now()}-${Math.random()}`;
+
+      before(async () => {
+        await PageObjects.console.monaco.clearEditorText();
+        // create an index with only 1 field
+        await PageObjects.console.monaco.enterText(`PUT ${indexName}/_doc/1\n{\n"test":1\n}`);
+        await PageObjects.console.clickPlay();
+      });
+
+      after(async () => {
+        await PageObjects.console.monaco.clearEditorText();
+        // delete the test index
+        await PageObjects.console.monaco.enterText(`DELETE ${indexName}`);
+        await PageObjects.console.clickPlay();
+      });
+
+      it('fields autocomplete only shows fields of the index', async () => {
+        await PageObjects.console.monaco.clearEditorText();
+        await PageObjects.console.monaco.enterText('GET _search\n{\n"fields": ["');
+
+        expect(await PageObjects.console.monaco.getAutocompleteSuggestion(0)).to.be.eql('test');
+        expect(await PageObjects.console.monaco.getAutocompleteSuggestion(1)).to.be.eql(undefined);
+      });
+    });
   });
 }
diff --git a/test/functional/page_objects/console_page.ts b/test/functional/page_objects/console_page.ts
@@ -77,7 +77,11 @@ export class ConsolePageObject extends FtrService {
     getAutocompleteSuggestion: async (index: number) => {
       const suggestionsWidget = await this.find.byClassName('suggest-widget');
       const suggestions = await suggestionsWidget.findAllByClassName('monaco-list-row');
-      const label = await suggestions[index].findByClassName('label-name');
+      const suggestion = suggestions[index];
+      if (!suggestion) {
+        return undefined;
+      }
+      const label = await suggestion.findByClassName('label-name');
       return label.getVisibleText();
     },
     pressUp: async (shift: boolean = false) => {