[Logs UI] Mark Log Stream for deprecation #186510

tonyghiani · 2024-06-20T09:06:26Z

📓 Summary

Due to Logs Explorer and Logs being 2 separate apps, it was more complicated to redirect the Logs default nav menu to Logs Explorer maintaining the same hierarchy on both the sidebar and the global search.
The implemented workaround redirects from the logs app to logs explorer once the main app route for logs UI is accessed, which should keep all the previous behaviours.

Screen.Recording.2024-06-20.at.15.15.53.mov

obltmachine · 2024-06-20T09:06:42Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

flash1293 · 2024-06-21T12:03:39Z

I think I wasn't really precise about this, sorry - I meant the beta tag should be on the "Logs" entry in the main nav menu (as it leads to the logs explorer, which is beta), not on the "Logs" section in the Observability menu.

I think it's OK to keep it on the "Explorer" entry on there.

tonyghiani · 2024-06-21T13:00:49Z

I think I wasn't really precise about this, sorry - I meant the beta tag should be on the "Logs" entry in the main nav menu (as it leads to the logs explorer, which is beta), not on the "Logs" section in the Observability menu.

In this case, it might not be a quick win because the sidebar entry is displayed using the app registration title, which does not support adding a beta badge or any other custom react node (the same value is used by the core application app to register the global search entry).

I can move back the Beta badge next to the Logs Explorer entry, but I don't think there is something quick we can do for a badge in the main sidenav entry, given the time constraint for 8.15.

flash1293 · 2024-06-21T13:02:05Z

Ah, wasn't aware we couldn't control this easily. OK, let's move it back then, I think it's OK that way

…-fix'

tonyghiani · 2024-06-26T07:09:36Z

@mdbirnstiehl could you please take a look at the copies for this work? Would be great if we can merge it before the feature freeze for 8.15 of next week.

elasticmachine · 2024-06-26T13:26:18Z

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

…hiani/kibana into 184992-log-stream-soft-deprecation

mdbirnstiehl

I had a few suggestions. Let me know if you have any issues or questions.

mdbirnstiehl · 2024-06-26T15:39:26Z

x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx

+  return (
+    <EuiCallOut
+      title={i18n.translate('xpack.infra.logsDeprecationCallout.euiCallOut.discoverANewLogLabel', {
+        defaultMessage: 'Discover a new Logs Exploration experience!',


Suggested change

defaultMessage: 'Discover a new Logs Exploration experience!',

defaultMessage: 'There's a new, better way to explore your logs!',

mdbirnstiehl · 2024-06-26T15:44:19Z

x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx

+    >
+      <p>
+        {i18n.translate('xpack.infra.logsDeprecationCallout.p.wereExcitedToIntroduceLabel', {
+          defaultMessage: `We're excited to introduce a powerful new way to explore logs.\nThis enhanced experience offers better performance and more intuitive navigation.`,


Suggested change

defaultMessage: `We're excited to introduce a powerful new way to explore logs.\nThis enhanced experience offers better performance and more intuitive navigation.`,

defaultMessage: `The new Logs Explorer makes viewing and inspecting your logs easier with more features, better performance, and more intuitive navigation.`,

mdbirnstiehl · 2024-06-26T15:53:56Z

x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx

+      <p>
+        {i18n.translate('xpack.infra.logsDeprecationCallout.p.weRecommendUsingTheLabel', {
+          defaultMessage:
+            'We recommend using the new Logs Explorer, as the Logs Stream will no longer be supported.',


Suggested change

'We recommend using the new Logs Explorer, as the Logs Stream will no longer be supported.',

'We recommend switching to Logs Explorer. As we focus on and continue to improve Logs Explorer, we'll no longer support Logs Stream.',

mdbirnstiehl · 2024-06-26T15:54:14Z

x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx

+        {...getLogsExplorerLinkProps(share)}
+      >
+        {i18n.translate('xpack.infra.logsDeprecationCallout.tryLogsExplorerButtonLabel', {
+          defaultMessage: 'Try Logs Explorer!',


Suggested change

defaultMessage: 'Try Logs Explorer!',

defaultMessage: 'Try Logs Explorer',

kibana-ci · 2024-06-26T16:21:09Z

💚 Build Succeeded

Buildkite Build
Commit: c7419ee
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-186510-c7419ee01582
Observability Deployment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1580	1581	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.5MB	1.5MB	+1.6KB
`logsExplorer`	247.2KB	247.3KB	+67.0B
total			+1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	101.8KB	101.8KB	+46.0B

History

💚 Build #217812 succeeded 01d4384
💛 Build #217175 was flaky 18c5681
💔 Build #217154 failed b819751
💔 Build #217102 failed 0eb0004

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

refactor(logs): mark log stream for deprecation

a8f44c0

tonyghiani added the release_note:skip Skip the PR/issue when compiling release notes label Jun 20, 2024

Marco Antonio Ghiani and others added 7 commits June 20, 2024 11:54

refactor(logs): update button and icon

633161f

refactor(logs): update redirect logic

5dedeea

Merge branch 'main' into 184992-log-stream-soft-deprecation

9171705

test(logs): fix tests

7bcbcb9

test(logs): remove legacy test

a0e1238

Merge branch 'main' into 184992-log-stream-soft-deprecation

0eb0004

test(logs): remove legacy test

1d0b435

Marco Antonio Ghiani and others added 3 commits June 21, 2024 15:02

refactor(logs): move back beta badge

b819751

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

cf7e78c

…-fix'

refactor(logs): update test

18c5681

Merge branch 'main' into 184992-log-stream-soft-deprecation

01d4384

tonyghiani marked this pull request as ready for review June 26, 2024 13:25

tonyghiani requested review from a team as code owners June 26, 2024 13:25

tonyghiani added the Team:obs-ux-logs Observability Logs User Experience Team label Jun 26, 2024

smith added the apm:review label Jun 26, 2024

neptunian approved these changes Jun 26, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 26, 2024

Marco Antonio Ghiani added 3 commits June 26, 2024 17:27

refactor(logs): remove panel badge

8c069db

Merge branch '184992-log-stream-soft-deprecation' of github.com:tonyg…

59607a7

…hiani/kibana into 184992-log-stream-soft-deprecation

refactor(logs): remove tsx file

c7419ee

tonyghiani removed the request for review from a team June 26, 2024 15:31

mdbirnstiehl reviewed Jun 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI] Mark Log Stream for deprecation #186510

[Logs UI] Mark Log Stream for deprecation #186510

tonyghiani commented Jun 20, 2024 •

edited

Loading

obltmachine commented Jun 20, 2024

flash1293 commented Jun 21, 2024

tonyghiani commented Jun 21, 2024

flash1293 commented Jun 21, 2024

tonyghiani commented Jun 26, 2024

elasticmachine commented Jun 26, 2024

mdbirnstiehl left a comment

mdbirnstiehl Jun 26, 2024

mdbirnstiehl Jun 26, 2024

mdbirnstiehl Jun 26, 2024

mdbirnstiehl Jun 26, 2024

kibana-ci commented Jun 26, 2024 •

edited

Loading

	defaultMessage: 'Discover a new Logs Exploration experience!',
	defaultMessage: 'There's a new, better way to explore your logs!',

	defaultMessage: `We're excited to introduce a powerful new way to explore logs.\nThis enhanced experience offers better performance and more intuitive navigation.`,
	defaultMessage: `The new Logs Explorer makes viewing and inspecting your logs easier with more features, better performance, and more intuitive navigation.`,

	'We recommend using the new Logs Explorer, as the Logs Stream will no longer be supported.',
	'We recommend switching to Logs Explorer. As we focus on and continue to improve Logs Explorer, we'll no longer support Logs Stream.',

	defaultMessage: 'Try Logs Explorer!',
	defaultMessage: 'Try Logs Explorer',

[Logs UI] Mark Log Stream for deprecation #186510

Are you sure you want to change the base?

[Logs UI] Mark Log Stream for deprecation #186510

Conversation

tonyghiani commented Jun 20, 2024 • edited Loading

📓 Summary

obltmachine commented Jun 20, 2024

🤖 GitHub comments

flash1293 commented Jun 21, 2024

tonyghiani commented Jun 21, 2024

flash1293 commented Jun 21, 2024

tonyghiani commented Jun 26, 2024

elasticmachine commented Jun 26, 2024

mdbirnstiehl left a comment

Choose a reason for hiding this comment

mdbirnstiehl Jun 26, 2024

Choose a reason for hiding this comment

mdbirnstiehl Jun 26, 2024

Choose a reason for hiding this comment

mdbirnstiehl Jun 26, 2024

Choose a reason for hiding this comment

mdbirnstiehl Jun 26, 2024

Choose a reason for hiding this comment

kibana-ci commented Jun 26, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

tonyghiani commented Jun 20, 2024 •

edited

Loading

kibana-ci commented Jun 26, 2024 •

edited

Loading