-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Mark Log Stream for deprecation #186510
[Logs UI] Mark Log Stream for deprecation #186510
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
I think I wasn't really precise about this, sorry - I meant the I think it's OK to keep it on the "Explorer" entry on there. |
In this case, it might not be a quick win because the sidebar entry is displayed using the app registration title, which does not support adding a beta badge or any other custom react node (the same value is used by the core application app to register the global search entry). I can move back the Beta badge next to the Logs Explorer entry, but I don't think there is something quick we can do for a badge in the main sidenav entry, given the time constraint for 8.15. |
Ah, wasn't aware we couldn't control this easily. OK, let's move it back then, I think it's OK that way |
@mdbirnstiehl could you please take a look at the copies for this work? Would be great if we can merge it before the feature freeze for 8.15 of next week. |
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
…hiani/kibana into 184992-log-stream-soft-deprecation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few suggestions. Let me know if you have any issues or questions.
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/logs_deprecation_callout.tsx
Outdated
Show resolved
Hide resolved
…logs_deprecation_callout.tsx Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…logs_deprecation_callout.tsx Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…logs_deprecation_callout.tsx Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
…logs_deprecation_callout.tsx Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
@mdbirnstiehl thanks for the suggestions! We'll also need to update the documentation with a deprecation warning on the tail logs page, do you think we should use a different callout content for that? Could you help with the change on the docs please? |
This is how the callout looks right now: @mdbirnstiehl Do we need both of the paragraphs? Seems like we can shorten it to a single one. Also, it says Logs Explorer a lot, reads a bit weird to me. Also, the bit about support could be interpreted that we don't support it anymore right now which isn't true, maybe "will be replaced by Logs Explorer in a future version" or something like that? |
@flash1293 We could reduce it like this: |
Love it, @mdbirnstiehl ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callout looks good to me, why did you remove a bunch of tests @tonyghiani ? It seems like it shouldn't change anything in that area?
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
It affects those tests because they were oriented on loading the logs app landing page, which corresponds to As we now have a redirect to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📓 Summary
Closes #184992
Due to
Logs Explorer
andLogs
being 2 separate apps, it was more complicated to redirect the Logs default nav menu to Logs Explorer maintaining the same hierarchy on both the sidebar and the global search.The implemented workaround redirects from the logs app to logs explorer once the main app route for logs UI is accessed, which should keep all the previous behaviours.
Screen.Recording.2024-06-20.at.15.15.53.mov