Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Turn on new Manifest Manager feature flag. #186596

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented Jun 21, 2024

Turns on feature flag introduced in #179698

Aligned tests - removed tests that were based on feature flag being present or not.

@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0 labels Jun 21, 2024
@szwarckonrad szwarckonrad self-assigned this Jun 21, 2024
@szwarckonrad
Copy link
Contributor Author

/ci

@szwarckonrad
Copy link
Contributor Author

/ci

Comment on lines -581 to -586
- x-pack/test/security_solution_api_integration/test_suites/security_solution_endpoint/configs/serverless.integrations_feature_flag.config.ts
- x-pack/test/security_solution_api_integration/test_suites/security_solution_endpoint/configs/integrations_feature_flag.config.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two suites were copies of the two above them that were initialized with the feature flag on. With the feature flag enabled, they are no longer needed.

@szwarckonrad szwarckonrad marked this pull request as ready for review June 21, 2024 15:51
@szwarckonrad szwarckonrad requested review from a team as code owners June 21, 2024 15:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@szwarckonrad
Copy link
Contributor Author

/ci

@szwarckonrad
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants