-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows] Turn on new Manifest Manager feature flag. #186596
Merged
szwarckonrad
merged 13 commits into
elastic:main
from
szwarckonrad:new-manifest-manager-turn-on-ff
Jul 1, 2024
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c0cdbb0
turn FF on
szwarckonrad 89f8da0
wip
szwarckonrad 4f93582
jest aligned
szwarckonrad 04c4b00
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad 77f9e3c
jest aligned
szwarckonrad 660208e
Merge remote-tracking branch 'origin/new-manifest-manager-turn-on-ff'…
szwarckonrad 8d1ea39
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad 92aeabe
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad 4059621
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad d1eea9c
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad c4a1d5a
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad 7087330
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad 6195787
Merge branch 'main' into new-manifest-manager-turn-on-ff
szwarckonrad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
567 changes: 118 additions & 449 deletions
567
...ity_solution/server/endpoint/services/artifacts/manifest_manager/manifest_manager.test.ts
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |
const pageObjects = getPageObjects(['common', 'artifactEntriesList']); | ||
const testSubjects = getService('testSubjects'); | ||
const browser = getService('browser'); | ||
const endpointArtifactTestResources = getService('endpointArtifactTestResources'); | ||
const endpointArtifactsTestResources = getService('endpointArtifactTestResources'); | ||
const endpointTestResources = getService('endpointTestResources'); | ||
const retry = getService('retry'); | ||
const esClient = getService('es'); | ||
|
@@ -51,9 +51,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |
.delete(`${EXCEPTION_LIST_URL}?list_id=${listId}&namespace_type=agnostic`) | ||
.set('kbn-xsrf', 'true'); | ||
}; | ||
// It's flaky only in Serverless | ||
// Failing: See https://github.com/elastic/kibana/issues/186004 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Were we able to fix the flakiness for this? |
||
describe.skip('@ess @serverless For each artifact list under management', function () { | ||
|
||
describe('@ess @serverless For each artifact list under management', function () { | ||
let indexedData: IndexedHostsAndAlertsResponse; | ||
let policyInfo: PolicyTestResourceInfo; | ||
|
||
|
@@ -73,13 +72,14 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |
// Check edited artifact is in the list with new values (wait for list to be updated) | ||
let updatedArtifact: ArtifactElasticsearchProperties | undefined; | ||
await retry.waitForWithTimeout('fleet artifact is updated', 120_000, async () => { | ||
const artifacts = await endpointArtifactTestResources.getArtifacts(); | ||
const artifacts = await endpointArtifactsTestResources.getArtifactsFromUnifiedManifestSO(); | ||
|
||
// This expects manifest artifact to come from unified so | ||
const manifestArtifact = artifacts.find((artifact) => { | ||
return ( | ||
artifact.artifactId === | ||
`${expectedArtifact.identifier}-${expectedArtifact.decoded_sha256}` && | ||
artifact.policyId === policy?.packagePolicy.id | ||
artifact.artifactIds.includes( | ||
`${expectedArtifact.identifier}-${expectedArtifact.decoded_sha256}` | ||
) && artifact.policyId === policy?.packagePolicy.id | ||
); | ||
}); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two suites were copies of the two above them that were initialized with the feature flag on. With the feature flag enabled, they are no longer needed.