[Fleet] Added modal to manage agent policies of an integration policy #186987

juliaElastic · 2024-06-26T13:32:45Z

Summary

Added modal to manage agent policies.

To verify:

go to an integration where the integration policies are listed
click on the + button in the agent policies column
click on Manage agent policies in the popover
add/remove agent policies in the modal
click submit, the integration policy should be updated to be linked to the updated agent policies

Made a change to the table column display to show a + button even if there is only one policy. Previously the popover could only be accessed if there are at least 2 agent policies.
Also restored the agent policy link, lock icon and revision display (instead of a badge) if there are multiple agent policies.
@simosilvestri Let me know if you have any UX recommendation as it differs slightly from the prototype.

EDIT: after discussing with Simona, removed the + button in case of a single agent policy assigned to the integration policy.

Disabling Manage agent policies button if the current user doesn't have at least write integration policies and write agent policies privilege.
This is how it looks with read privileges:

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

obltmachine · 2024-06-26T13:32:59Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

juliaElastic · 2024-06-26T13:44:11Z

/ci

juliaElastic · 2024-06-26T14:09:17Z

/ci

juliaElastic · 2024-06-27T07:31:41Z

/ci

simosilvestri · 2024-06-27T12:03:19Z

Hi @juliaElastic, as we discussed, we can remove the badge with the plus icon when displaying a single Agent policy, since we expect that the majority of customers will go back to the Integration wizard to edit their settings.

juliaElastic · 2024-06-27T12:19:52Z

/ci

juliaElastic · 2024-06-27T12:22:07Z

There are 2 remaining issues that I noticed:

after submitting the Manage agent policies modal, the Integration list UI doesn't refresh with the changes, should refresh automatically - this is fixed
the managed agent policies are not showing up in the combo box (this is an existing behaviour). I think they should be visible and shouldn't be removed
- looked into this to show the managed policies in the combo, but didn't find a way to prevent removing them. Instead I went with a solution to keep them hidden, but always keep them in the policy_ids list, so the managed policies are not removed when updating an integration policy.

elasticmachine · 2024-06-27T12:52:35Z

Pinging @elastic/fleet (Team:Fleet)

criamico · 2024-07-02T08:11:20Z

I'm testing locally and I have two small observations about this modal:

When loading, the modal size briefly changes, it's not a big issue but it looks weird. It seems to happen when the modal loads the policies, so having a fixed min-width or something like this could help. I captured it in a quick video:

Screen.Recording.2024-07-02.at.10.04.26.mov

The font size in the callout description is a bit too big (looks the same as the title)

criamico · 2024-07-02T08:14:47Z

...agent_policy/create_package_policy_page/components/steps/components/agent_policy_options.tsx

+import { isPackageLimited } from '../../../../../../../../../common/services';
+import { useGetAgentPolicies, useGetOutputs, useGetPackagePolicies } from '../../../../../../hooks';
+
+export function useAgentPoliciesOptions(packageInfo?: PackageInfo) {


Thanks for extracting this function!

criamico · 2024-07-02T08:17:00Z

x-pack/plugins/fleet/public/components/manage_agent_policies_modal.tsx

+          <EuiText>
+            <FormattedMessage
+              id="xpack.fleet.manageAgentPolicies.confirmModalDescription"
+              defaultMessage="Agent policies which share this integration"


maybe it would sound better Agent policies sharing this integration?

good idea, updated

juliaElastic · 2024-07-02T08:52:44Z

Added min-width to the modal, so it shouldn't jump (it happened with at least 3 policies).
Also decreased the callout description text size:

criamico

Tested with the new changes, LGTM 🚢

kibana-ci · 2024-07-02T12:21:10Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 0907247

Failed CI Steps

Jest Integration Tests #3

Test Failures

[job] [logs] Jest Integration Tests #3 / migration actions checkClusterRoutingAllocation resolves left when cluster.routing.allocation.enabled is incompatible
[job] [logs] Jest Integration Tests #3 / migration actions checkClusterRoutingAllocation resolves right when cluster.routing.allocation.enabled=all
[job] [logs] Jest Integration Tests #3 / migration actions cloneIndex resolves left cluster_shard_limit_exceeded when the action would exceed the maximum normal open shards
[job] [logs] Jest Integration Tests #3 / migration actions cloneIndex resolves left index_not_found_exception if the source index does not exist
[job] [logs] Jest Integration Tests #3 / migration actions cloneIndex resolves left with a index_not_green_timeout if clone target already exists but takes longer than the specified timeout before turning green
[job] [logs] Jest Integration Tests #3 / migration actions cloneIndex resolves right if clone target already existed after waiting for index status to be green
[job] [logs] Jest Integration Tests #3 / migration actions cloneIndex resolves right if cloning into a new target index
[job] [logs] Jest Integration Tests #3 / migration actions fetchIndices includes the _meta data of the indices in the response
[job] [logs] Jest Integration Tests #3 / migration actions fetchIndices resolves right empty record if no indices were found
[job] [logs] Jest Integration Tests #3 / migration actions fetchIndices resolves right record with found indices
[job] [logs] Jest Integration Tests #3 / migration actions removeWriteBlock rejects if there is a non-retryable error
[job] [logs] Jest Integration Tests #3 / migration actions removeWriteBlock resolves right if successful when an index already has a write block
[job] [logs] Jest Integration Tests #3 / migration actions removeWriteBlock resolves right if successful when an index does not have a write block
[job] [logs] Jest Integration Tests #3 / migration actions setWriteBlock once resolved, prevents further writes to the index
[job] [logs] Jest Integration Tests #3 / migration actions setWriteBlock resolves left index_not_found_exception when the index does not exist
[job] [logs] Jest Integration Tests #3 / migration actions setWriteBlock resolves right when setting a write block on an index that already has one
[job] [logs] Jest Integration Tests #3 / migration actions setWriteBlock resolves right when setting the write block succeeds
[job] [logs] Jest Integration Tests #3 / migration actions waitForIndexStatus resolves left with "index_not_green_timeout" after waiting for an index status to be green timeout
[job] [logs] Jest Integration Tests #3 / migration actions waitForIndexStatus resolves left with "index_not_yellow_timeout" after waiting for an index status to be yellow timeout
[job] [logs] Jest Integration Tests #3 / migration actions waitForIndexStatus resolves right after waiting for an index status to be yellow if the index already existed

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	1206	1208	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.8MB	1.8MB	+5.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	167.2KB	167.2KB	-9.0B

Unknown metric groups

async chunk count

id	before	after	diff
`fleet`	11	10	-1

History

💔 Build #219022 failed c889881
💛 Build #218983 was flaky 99fa3df
💔 Build #218982 failed c0c51fe
💛 Build #218442 was flaky 08a3f5c
💛 Build #218386 was flaky d56993c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

manage agent policies

e534a63

juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Jun 26, 2024

Merge branch 'main' into manage-agent-policies

8a8e888

fix imports

57fe4a8

juliaElastic and others added 2 commits June 27, 2024 09:16

Merge branch 'main' into manage-agent-policies

bcab0c6

fix test

fb0e939

juliaElastic self-assigned this Jun 27, 2024

disable manage button if no privileges

c11e6af

removed + for single policy, added unit test

a04a8df

juliaElastic marked this pull request as ready for review June 27, 2024 12:20

juliaElastic requested a review from a team as a code owner June 27, 2024 12:20

refresh table after updating agent policies

0a4516f

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 27, 2024

juliaElastic added 6 commits June 27, 2024 15:42

keep managed policy ids

aabc753

moved managed logic to agent policy multi select

d56993c

added unit test

4ed9249

added unit test

d35e477

fixed edge case when one option is available

31d3980

fix condition

08a3f5c

jen-huang self-requested a review June 28, 2024 18:04

juliaElastic and others added 2 commits July 2, 2024 08:29

Merge branch 'main' into manage-agent-policies

c0c51fe

fix import

99fa3df

criamico self-requested a review July 2, 2024 07:04

criamico reviewed Jul 2, 2024

View reviewed changes

fix review comments

028a9a2

fix review comments

c889881

criamico approved these changes Jul 2, 2024

View reviewed changes

juliaElastic enabled auto-merge (squash) July 2, 2024 09:30

Merge branch 'main' into manage-agent-policies

0907247

juliaElastic merged commit 813fc21 into elastic:main Jul 2, 2024
21 checks passed

kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Added modal to manage agent policies of an integration policy #186987

[Fleet] Added modal to manage agent policies of an integration policy #186987

juliaElastic commented Jun 26, 2024 •

edited

Loading

obltmachine commented Jun 26, 2024

juliaElastic commented Jun 26, 2024

juliaElastic commented Jun 26, 2024

juliaElastic commented Jun 27, 2024

simosilvestri commented Jun 27, 2024

juliaElastic commented Jun 27, 2024

juliaElastic commented Jun 27, 2024 •

edited

Loading

elasticmachine commented Jun 27, 2024

criamico commented Jul 2, 2024

criamico Jul 2, 2024

criamico Jul 2, 2024

juliaElastic Jul 2, 2024

juliaElastic commented Jul 2, 2024

criamico left a comment

kibana-ci commented Jul 2, 2024

async chunk count

[Fleet] Added modal to manage agent policies of an integration policy #186987

[Fleet] Added modal to manage agent policies of an integration policy #186987

Conversation

juliaElastic commented Jun 26, 2024 • edited Loading

Summary

Checklist

obltmachine commented Jun 26, 2024

🤖 GitHub comments

juliaElastic commented Jun 26, 2024

juliaElastic commented Jun 26, 2024

juliaElastic commented Jun 27, 2024

simosilvestri commented Jun 27, 2024

juliaElastic commented Jun 27, 2024

juliaElastic commented Jun 27, 2024 • edited Loading

elasticmachine commented Jun 27, 2024

criamico commented Jul 2, 2024

criamico Jul 2, 2024

Choose a reason for hiding this comment

criamico Jul 2, 2024

Choose a reason for hiding this comment

juliaElastic Jul 2, 2024

Choose a reason for hiding this comment

juliaElastic commented Jul 2, 2024

criamico left a comment

Choose a reason for hiding this comment

kibana-ci commented Jul 2, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

juliaElastic commented Jun 26, 2024 •

edited

Loading

juliaElastic commented Jun 27, 2024 •

edited

Loading