Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Technical debt #19590

Closed
3 tasks
sorenlouv opened this issue May 31, 2018 · 8 comments
Closed
3 tasks

[APM] Technical debt #19590

sorenlouv opened this issue May 31, 2018 · 8 comments
Labels
Team:APM All issues that need APM UI Team support

Comments

@sorenlouv
Copy link
Member

sorenlouv commented May 31, 2018

Technical debt in APM UI:

  • Re-think routing, link handling and url params
  • Single, standardized config and types for charts (response time, throughout (rpm), breakdown and metrics)
  • Get rid of minimumBucketSize and bucketTargetCount from config. There is no need for them to be configurable. The current numbers are also arbitrary.

Dependencies

The following dependencies are especially important for APM to keep up to date.

Runtime dependencies:

  • react, react-dom
  • styled-components
  • react-syntax-highlighter (plan is to move to codesearch)
  • react-vis (plan is to move to EUI vis)

Dev dependencies:

  • typescript
  • jest
  • jest-styled-components
  • react-testing-library
@sorenlouv sorenlouv added the Team:APM All issues that need APM UI Team support label May 31, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@jasonrhodes
Copy link
Member

Re: "Replace KUI component with EUI: Breadcrumbs" ... it sounds like there are some substantial changes coming in Kibana 7 with how Kibana builds the top of the page/breadcrumbs etc and the available API for that for x-pack plugins. We may want to leave what we have for now and revisit when that becomes more clear.

@alvarolobato
Copy link

I've removed the charts task, it is already here: #18145

@makwarth
Copy link

Respect Kibana time format setting: Currently APM doesn't respect the user's Kibana settings regarding date/time formats. Most places that shows time are hardcoded to 24-hour format.

Will this make it into 6.5?

@makwarth
Copy link

It'd close #18153

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 12, 2018

Closes #18153.

Will this make it into 6.5?

I'll create an issue, and then we should prioritize next week.

@sorenlouv
Copy link
Member Author

@makwarth Created #22962 and removed it from the list above

@makwarth
Copy link

@sqren 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants