Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Close this dialog" can be "close inspector" for screenreader for the close inspector button on inspector. #20688

Closed
bhavyarm opened this issue Jul 11, 2018 · 1 comment · Fixed by #21719
Closed

"Close this dialog" can be "close inspector" for screenreader for the close inspector button on inspector. #20688

bhavyarm opened this issue Jul 11, 2018 · 1 comment · Fixed by #21719
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 6.4.0 snapshot

Browser version: chrome latest

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: When we focus on close button on inspector - screenreader reads it as close dialog. Can we change this close inspector?

Steps to reproduce:

  1. Use voiceover
  2. Access inspector through keyboard
  3. Close button is announced as close dialog.

Screenshots (if relevant):

close_dialog
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Feature:Inspector Inspector infrastructure and implementations labels Jul 11, 2018
@timroes timroes added the EUI label Jul 19, 2018
@timroes
Copy link
Contributor

timroes commented Jul 19, 2018 •
edited
Loading

I created elastic/eui#1031 to give EUI the possibility to overwrite the close button label. Once that is released and pulled into Kibana, we can fix this issue.

@timroes timroes mentioned this issue Aug 7, 2018
Merged
@bhavyarm bhavyarm mentioned this issue Aug 22, 2018
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add proper aria-label for close inspector timroes/kibana
2 participants
@timroes @bhavyarm