Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply visualization changes automatically if they are valid #20862

Closed
JacobBrandt opened this issue Jul 16, 2018 · 2 comments
Closed

Apply visualization changes automatically if they are valid #20862

JacobBrandt opened this issue Jul 16, 2018 · 2 comments
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@JacobBrandt
Copy link
Contributor

Describe the feature:
It would be really beneficial if the changes you make to a visualization when editing are applied as you make them without needing to push Apply changes.

Describe a specific use case for the feature:
It's annoying to have to continually push the Apply changes button and users would rather be able to quickly see the difference between settings without needing this extra step. It should only apply when the changes are valid (this is detectable because the Apply changes button becomes clickable). Text input fields should have a pretty high debounce with this option though

With this change remove the Apply changes button and change the Discard changes button to Reset which would reset the visualization to a state before you were in edit mode.

Editing an existing visualization would go to its saved state.
Editing a new visualization would go to its default state.

@timroes timroes added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Jul 18, 2018
@timroes
Copy link
Contributor

timroes commented Jul 18, 2018

Hi Jacob,

this can already be enabled in the current editor on a visualization implementation basis (e.g. Vega visualizations have this enabled). The reason not to have this on by default, was to not kill too large clusters while editing.

Nevertheless we know that this is a bad usability, and we want to fix this. We are currently building a new editor and having not to hit apply all the time is something that we for sure will build into the new editor (#17076).

I also added that specific thought to the technical challenges list for the new editor: https://github.com/elastic/kibana/projects/5

Since we won't change that behavior in the old editor anymore, I will close this issue in favor of the above mentioned ticket and the new editor effort.

Cheers,
Tim

@timroes timroes closed this as completed Jul 18, 2018
@JacobBrandt
Copy link
Contributor Author

Thanks, I looked over the new editor ticket. We have some of those some complaints about the current editor so it's good to see that those are also being looked into.

I understand the concern of the data requests killing the clusters from subtle changes which is why I suggested a debounce of sorts. Basically a slight delay for data request options.
So I was imagining this....

  1. Options that request for data (slight delay)
  2. Options that change the look of the visualization (always apply)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

No branches or pull requests

2 participants