Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] DT design polish II #24578

Closed
6 of 7 tasks
formgeist opened this issue Oct 25, 2018 · 13 comments · Fixed by #24862
Closed
6 of 7 tasks

[APM] DT design polish II #24578

formgeist opened this issue Oct 25, 2018 · 13 comments · Fixed by #24862
Assignees
Labels
Team:APM All issues that need APM UI Team support v6.5.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Oct 25, 2018

Splitting up the mega issue and porting over more polish tasks from the original issue which isn't addressed in #24556


Remove beta labels

Machine Learning

We have beta labels in the Machine Learning integration flyout and integration popover we need to remove as the ML integration goes GA in 6.5

Screen Shot 2018-09-04 at 15.13.11.png

Screen Shot 2018-09-04 at 15.13.15.png

  • Remove (beta) from popover link
  • Remove beta label from Flyout content

Search bar

The search bar will become GA in 6.5, so this is a reminder issue to remove the beta label for 6.5.

Screen Shot 2018-09-04 at 15.31.37.png

  • Remove beta label from search bar

Timeline visual regression

There used to be a minimum width for transactions/spans, so they were visible. Also, the text would flow left when there was no more space on the right.

Before:
before image

After:
after image

Previous implementation: https://github.com/sqren/kibana/blob/a353979ebbca723bde1f07e0bfe2acf9241ad3e0/x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/Spans/Span.js#L30-L45

Codepen demonstrating the solution: https://codepen.io/sqren/pen/JrXNjY

  • Revert right-to-left regression

Note: if easy, add a minimum width to the span items as well, which will close #18680

  • Add min width to span (maybe, if easy)

Sample tabs navigation

screenshot 2018-10-24 at 09 32 19

screenshot 2018-10-24 at 09 32 29

It looks like the tabs navigation is not showing active state on Timeline when entering a Transaction detail page nor selecting a new sample from the distribution. Additionally, there's no border-bottom on the active item once it's active, since it's hidden by the grey horizontal divider between the sample header and the tab content.

  • Fix tab navigation and active state

Marks vertical lines

Looks like the dot is not longer resting on the x-axis horizontal line but sinks a little deeper. Probably means moving the x-axis labels a little further up from the x-axis line so there's space for the mark dots to appear underneath.

The mark on the right is a fixed mark
marks-fix

  • Resolve mark inconsistency and spacing (move x-axis label up 5 px to make room for the dots to slide along the bottom of the axis)
@formgeist formgeist added Team:APM All issues that need APM UI Team support v6.5.0 labels Oct 25, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist
Copy link
Contributor Author

@jasonrhodes Can you confirm that the stick properties was fixed on the Error group detail page?

@formgeist formgeist mentioned this issue Oct 25, 2018
12 tasks
@formgeist
Copy link
Contributor Author

Added a minor polish fix to Context tables by adding some more line-height to the cells.

@makwarth
Copy link

Add Traces route change to the description

@formgeist
Copy link
Contributor Author

@makwarth We have an issue which is moved to 6.6 #23824 - we can obviously discuss if it's important enough to implement now over something else, but it feels like new functionality.

@makwarth
Copy link

@formgeist Ah, hadn't seen that one. 6.6 sounds fine with me. I'll remove it again from this issue.

@jasonrhodes
Copy link
Member

Current histogram state has been moved to #24740

@jasonrhodes
Copy link
Member

  • Fix service legend
  • Add Services label in front of services legend
  • Include services legend in the locked element when scrolling a large timeline

These 3 ^^ moved to #24741

@formgeist
Copy link
Contributor Author

Added PR fix for the line-height issue in the PropertiesTable #24768

@jasonrhodes
Copy link
Member

Confirming that the error group sticky properties margin has been fixed outside this ticket. I removed that and the line-height issue as I think it's clearer to only use the green checkmark to denote things that are done in this ticket.

@jasonrhodes
Copy link
Member

Also: I just added in the visual regression here too, to cut down on PR churn. That replaces #24817

@jasonrhodes
Copy link
Member

Moved the beta label removals in here too as they are incredibly simple, no need to have separate tickets and CI builds for each. :)

@formgeist
Copy link
Contributor Author

@jasonrhodes Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v6.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants