Polish 6.5 #24556

jasonrhodes · 2018-10-25T02:59:24Z

Closes #24475 (details are all there)

Closes #24618 also

Normalizing heading styles:

Timeline item styles

Sample section shadow removed

Transaction flyout updates

Span flyout updates

elasticmachine · 2018-10-25T03:20:00Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-25T05:38:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-25T10:49:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

jasonrhodes · 2018-10-25T11:03:35Z

retest

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx

x-pack/plugins/apm/public/components/app/TransactionDetails/Distribution/index.tsx

elasticmachine · 2018-10-25T13:13:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx

formgeist · 2018-10-25T14:18:17Z

Getting some pretty heavy problems when loading from a Service -> Transaction view...

fatal_errors_service.tsx:36 Error: Uncaught TypeError: Cannot read property 'find' of undefined (http://localhost:5601/qhe/bundles/commons.bundle.js:232111)
    at window.onerror (notify.js:156)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:138)
    at invokeGuardedCallback (react-dom.development.js:187)
    at replayUnitOfWork (react-dom.development.js:11318)
    at renderRoot (react-dom.development.js:11885)
    at performWorkOnRoot (react-dom.development.js:12449)
    at performWork (react-dom.development.js:12370)
    at performSyncWork (react-dom.development.js:12347)
    at requestWork (react-dom.development.js:12247)
    at scheduleWorkImpl (react-dom.development.js:12122)
    at scheduleWork (react-dom.development.js:12082)
    at Object.enqueueSetState (react-dom.development.js:6644)
    at Connect.Component.setState (react.development.js:238)
    at Connect.onStateChange (connectAdvanced.js:222)
    at Object.dispatch (redux.js:227)
    at dispatch (<anonymous>:1:38223)
FatalErrorsService.add @ fatal_errors_service.tsx:36
react-dom.development.js:11330 Uncaught TypeError: Cannot read property 'find' of undefined
    at waterfall.ts:17
    at index.js:76
    at index.js:36
    at index.js:90
    at index.js:36
    at Function.mapStateToProps [as mapToProps] (index.ts:15)
    at mapToPropsProxy (wrapMapToProps.js:54)
    at handleNewState (selectorFactory.js:63)
    at handleSubsequentCalls (selectorFactory.js:80)
    at pureFinalPropsSelector (selectorFactory.js:85)
    at Object.runComponentSelector (connectAdvanced.js:43)
    at Connect.onStateChange (connectAdvanced.js:216)
    at Object.dispatch (redux.js:227)
    at dispatch (<anonymous>:1:38223)
    at index.js:14
    at Object.dispatch (throttle.js:42)
fatal_errors_service.tsx:38 Uncaught Error: Uncaught TypeError: Cannot read property 'find' of undefined (http://localhost:5601/qhe/bundles/commons.bundle.js:232111)
    at window.onerror (notify.js:156)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:138)
    at invokeGuardedCallback (react-dom.development.js:187)
    at replayUnitOfWork (react-dom.development.js:11318)
    at renderRoot (react-dom.development.js:11885)
    at performWorkOnRoot (react-dom.development.js:12449)
    at performWork (react-dom.development.js:12370)
    at performSyncWork (react-dom.development.js:12347)
    at requestWork (react-dom.development.js:12247)
    at scheduleWorkImpl (react-dom.development.js:12122)
    at scheduleWork (react-dom.development.js:12082)
    at Object.enqueueSetState (react-dom.development.js:6644)
    at Connect.Component.setState (react.development.js:238)
    at Connect.onStateChange (connectAdvanced.js:222)
    at Object.dispatch (redux.js:227)
    at dispatch (<anonymous>:1:38223)
react-dom.development.js:9643 The above error occurred in the <Connect(TransactionDetailsView)> component:
    in Connect(TransactionDetailsView) (created by Route)
    in Route (created by Main)
    in div (created by styled.div)
    in styled.div (created by Main)
    in Main
    in Router
    in Provider

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.

formgeist · 2018-10-25T14:21:04Z

Looks like it happens for opbeans-python perhaps because it's not the full trace. Not sure, but you can reproduce by entering that service, choose a transaction from the list.

formgeist · 2018-10-25T14:21:49Z

The style changes are looking 👍

sorenlouv · 2018-10-25T14:28:39Z

...ponents/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/SpanFlyout/index.tsx

-            </EuiTitle>
-          </EuiFlexItem>
+    <EuiPortal>
+      <EuiFlyout onClose={onClose} size="m" ownFocus={true}>


ownFocus should be enough (omit ={true}. It used to give a warning in eslint - maybe tslint is not as strict? 🤔

Btw. is the EuiPortal required for the ownFocus stuff?

@sqren should be enough for what?

Should be enough for it to work, and is consistent with the rest of the codebase :)

<EuiFlyout onClose={onClose} size="m" ownFocus>

We are currently using the default setting in eslint:
https://github.com/sqren/kibana/blob/001d22f885614c19ebe9c020d7a1e7b177b1d6f5/.eslintrc.js#L372

ESLint rule:
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md

Again, just a minor nit. I think the more important thing is to ensure that the lint rules for eslint/tslint are more aligned.

Note to self: add this to our tslint setup https://github.com/palantir/tslint-react

Oh I see what you're saying now. IMO we should change the lint rules to force ={true} because as I understand it, React wants to eventually make bare attributes work the same way object shorthand works, like const ownFocus = true; const a = { ownFocus }; so I have just gotten in the habit of being explicit with the boolean value. But yeah, that seems auto-fixable tbh.

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx

sorenlouv · 2018-10-25T15:08:55Z

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx

  totalDuration: number;
  item: IWaterfallItem;
  color: string;
  isSelected: boolean;
  onClick: () => any;
 }

+function Prefix({ item }: { item: IWaterfallItem }) {


Should we call it TransactionPrefixIcon just to be super clear?

I have a feeling which ones get prefixed and with what is going to change a bunch and this is a "private" component. Could be "WaterfallItemPrefix" if we are worried about stack traces maybe?

Not following you completely. Are you saying this is currently an icon that prefixes Transactions, but that will change in the future? Or what would you say it does?

elasticmachine · 2018-10-25T15:26:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-25T16:24:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

formgeist · 2018-10-25T17:47:26Z

Hmm.. what happened to the coloured graphs in the Timeline?

jasonrhodes · 2018-10-25T18:26:50Z

Hmm.. what happened to the coloured graphs in the Timeline?

no idea! I'm not seeing that locally

jasonrhodes · 2018-10-25T18:30:05Z

Looks like it happens for opbeans-python perhaps because it's not the full trace. Not sure, but you can reproduce by entering that service, choose a transaction from the list.

Hm, I'm using cloud data and there is no opbeans-python service running there. Can you reproduce anywhere in cloud?

jasonrhodes · 2018-10-25T18:43:05Z

@formgeist ok I switched my local dev to point to the v1 cluster and I can see the error now in opbeans-python. Will take a look and roll it out to a new ticket if it's not a simple little fix.

jasonrhodes · 2018-10-25T19:08:10Z

@formgeist ha I also see the missing bars in the timeline for v1 -- investigating now.

elasticmachine · 2018-10-25T20:52:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sorenlouv · 2018-10-25T21:23:12Z

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx

  position: relative;
-  height: ${unit}px;
+  height: px(${unit});


Let's try this suggestion thing again :D

Suggested change

height: px(${unit});

height: ${px(unit)};

elasticmachine · 2018-10-26T01:59:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-26T04:20:49Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

jasonrhodes · 2018-10-26T11:41:52Z

retest

elasticmachine · 2018-10-26T13:51:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com>

…n-deterministic per test run

jasonrhodes · 2018-10-26T16:21:15Z

retest

elasticmachine · 2018-10-26T16:21:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-26T18:36:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Updates waterfall item design for timeline rows * Adjusts span and tx flyouts and updates tooltips to EUI * Heading size fixes and clean up * Updates tooltip snapshots * Review tweaks and snapshot updates * Revert experiment :) Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com> * Fixes bug with v1 waterfall state * Fixes bug with timeline bar height * Updates snapshot tests * Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run

* Translate global navigation bar component (#23993) Translate global navigation bar component * [backport] add back earlier 6.x minor versions We still backport to these branches, primarily for doc changes. * [dev/build] fix invalid assertion * Skip this test until snapshots are updated (#24650) * Feat/expression threading (#24598) Replaces #23301 Closes #23080 --- This is a minimal threading implementation for Canvas. There's still a lot to be done to make this concept great, but this is a start. What it does: - Creates a server side abstraction on top of the interpreter - Determines where to send the expression by checking the first function to be run - Loads common functions in a separate worker thread on the server. - Routes to a single forked worker (thread), the main thread (server), or the browser (browser), in that order - Defers back to the router when a function isn't found. Fails if the function isn't found in any of the above 3 environments - Times out the worker if it takes too long, and respawns it as needed. - Simplifies the error dialog to remove the stack. What is does not.: - Round robin a pool of workers - Queue. If one expression in the threaded env fails then anything sent to it in the meantime will fail. The upstream environment handles managing timeouts. I think this would only make sense todo with a pool. - Client side. This doesn't implement web workers, but we could use roughly the same architecture. - Implement a specific, pluggable `worker` environment on the server. Right now it's just common functions, so plugin authors will always end up in a thread if they put their function in the common directory. What I don't like: - The socketProvider code. This was reused across the server & browser, but now that it's only used in the browser there's no good reason for the abstraction - The serialize/deserialize stuff feels messy. Do we really need serialization? * Polish 6.5 (#24556) * Updates waterfall item design for timeline rows * Adjusts span and tx flyouts and updates tooltips to EUI * Heading size fixes and clean up * Updates tooltip snapshots * Review tweaks and snapshot updates * Revert experiment :) Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com> * Fixes bug with v1 waterfall state * Fixes bug with timeline bar height * Updates snapshot tests * Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run * Don't throw errors in optimizer (#24660) * Fixed label position on progress elements (#24623) * [kbn/es] add context to error message (#24664) This just tweaks the kbn-es error message to provide more context than just `Not Found` * [BeatsCM] Beats without tags should return an empty array via the config API (#24665) * [ML] Change file data visualizer JSON format label to NDJSON (#24643) * [ML] Change file datavisualizer JSON format label to NDJSON * [ML] Update edit flyout overrides snapshot * Translations for Coordinate Map (#23952) translate Coordinate Map * Translations for Region Map (#23875) add translations for region_map plugin * [Tools] Add TemplateLiteral parsing to i18n_check tool (#24580) * [Tools] Add TemplateLiteral parsing to i18n_check tool * Add comments * [ML] Remove obsolete sentence from info tooltip. (#24716) * Translate security/users component (#23940) Translate security/users * [Docs] Remove beta notes for ML and Query bar (#24718) * Translations for Table Vis plugin (#23679) add translations for table vis plugin * Feature/translate new nav bar (#24326) translate new_nav_bar * center content in fullscreen mode, hide K7 top nav (#24589) * [APM] Fixes rare cases where KibanaLink is loaded outside of React context (#24705) * Fixes rare cases where KibanaLink will be loaded outside of React context and requires no redux connect dependency * Fixes tests for updated Kibana link component * Removes obsolete snapshot * Secops structure code (#24652) * add basic structure for secops application * finalize skeleton for secops * fix type issue and hapi new version * remove route home, not needed for now * Add configuration + delete noise * prepend elastic license to generated file * Cut down on all tests except for secops tests and one example of infr… (#24693) * Cut down on all tests except for secops tests and one example of infra integration tests * Commented out code for only this branch * Added comments and "please see issue number" * https://github.com/elastic/ingest-dev/issues/60

* Updates waterfall item design for timeline rows * Adjusts span and tx flyouts and updates tooltips to EUI * Heading size fixes and clean up * Updates tooltip snapshots * Review tweaks and snapshot updates * Revert experiment :) Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com> * Fixes bug with v1 waterfall state * Fixes bug with timeline bar height * Updates snapshot tests * Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run

* Polish 6.5 (#24556) * Updates waterfall item design for timeline rows * Adjusts span and tx flyouts and updates tooltips to EUI * Heading size fixes and clean up * Updates tooltip snapshots * Review tweaks and snapshot updates * Revert experiment :) Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com> * Fixes bug with v1 waterfall state * Fixes bug with timeline bar height * Updates snapshot tests * Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run * Add a console.error to visualize errors (#24581) (#24867) * [6.5] [Rollups] Fix i18n bugs (#23848) (#24871) * [Rollups] Fix i18n bugs (#23848) * Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error. * Localize no default index pattern message. * Localize es interval errors. * Localize job action menu and confirm delete modal. * Remove unnecessary use of injectI18n from tabs. * Localize job status. * Localize steps. * Remove template literals from FormattedMessages. * Remove accidental security addition to translation file. * [APM] fixes #24563 by de-duping the column field id 'sample' (#24690) (#24877) * [APM] fixes #24563 by replacing de-duping the twice-used column field id * [APM] fixed issue with service column not sorting in ManagedTable * [APM] make render field on ITableColumn optional and allowing it to use EUI's default value * Add 6.5 to .backportrc.json * [APM] Removes action menus (#24748) * Removes infra links and replaces context menu with single discover links for now * Changes discover links to use empty button style

jasonrhodes requested review from sorenlouv and formgeist October 25, 2018 10:27

formgeist requested changes Oct 25, 2018

View reviewed changes

formgeist mentioned this pull request Oct 25, 2018

[APM] DT design polish II #24578

Closed

7 tasks

sorenlouv reviewed Oct 25, 2018

View reviewed changes

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx Show resolved Hide resolved

formgeist approved these changes Oct 25, 2018

View reviewed changes

sorenlouv reviewed Oct 25, 2018

View reviewed changes

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx Outdated Show resolved Hide resolved

sorenlouv reviewed Oct 25, 2018

View reviewed changes

...components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/WaterfallItem.tsx Show resolved Hide resolved

sorenlouv reviewed Oct 25, 2018

View reviewed changes

This was referenced Oct 26, 2018

Waterfall request breaks on a v1 transaction elastic/apm#6

Closed

[APM] Waterfall request breaks on a v1 transaction #24618

Closed

jasonrhodes force-pushed the polish-6.5 branch from 9cfdee4 to 36114c6 Compare October 26, 2018 14:04

jasonrhodes and others added 10 commits October 26, 2018 11:41

Updates waterfall item design for timeline rows

b6f7457

Adjusts span and tx flyouts and updates tooltips to EUI

5deb5b3

Heading size fixes and clean up

07718fa

Updates tooltip snapshots

74615f1

Review tweaks and snapshot updates

97576c3

Revert experiment :)

3c527bb

Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com>

Fixes bug with v1 waterfall state

bd861e7

Fixes bug with timeline bar height

7920fdb

Updates snapshot tests

c2d2c2f

Updated test so it doesn't mount and rely on EUI makeId() which is no…

2e113de

…n-deterministic per test run

jasonrhodes force-pushed the polish-6.5 branch from 5d9c062 to 2e113de Compare October 26, 2018 15:43

jasonrhodes merged commit 3a2db6e into elastic:master Oct 26, 2018

jasonrhodes deleted the polish-6.5 branch October 26, 2018 18:56

jasonrhodes mentioned this pull request Oct 26, 2018

[6.x] Polish 6.5 (#24556) #24688

Merged

jasonrhodes mentioned this pull request Oct 26, 2018

[6.5] Polish 6.5 (#24556) #24689

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Polish 6.5 #24556

Polish 6.5 #24556

jasonrhodes commented Oct 25, 2018 •

edited

elasticmachine commented Oct 25, 2018

elasticmachine commented Oct 25, 2018

elasticmachine commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

elasticmachine commented Oct 25, 2018

formgeist commented Oct 25, 2018

formgeist commented Oct 25, 2018

formgeist commented Oct 25, 2018

sorenlouv Oct 25, 2018

sorenlouv Oct 25, 2018

jasonrhodes Oct 25, 2018

sorenlouv Oct 25, 2018 •

edited

sorenlouv Oct 25, 2018 •

edited

jasonrhodes Oct 25, 2018

sorenlouv Oct 25, 2018

jasonrhodes Oct 25, 2018

sorenlouv Oct 25, 2018

elasticmachine commented Oct 25, 2018

elasticmachine commented Oct 25, 2018

formgeist commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

elasticmachine commented Oct 25, 2018

sorenlouv Oct 25, 2018

elasticmachine commented Oct 26, 2018

elasticmachine commented Oct 26, 2018

jasonrhodes commented Oct 26, 2018

elasticmachine commented Oct 26, 2018

jasonrhodes commented Oct 26, 2018

elasticmachine commented Oct 26, 2018

elasticmachine commented Oct 26, 2018

Polish 6.5 #24556

Polish 6.5 #24556

Conversation

jasonrhodes commented Oct 25, 2018 • edited

elasticmachine commented Oct 25, 2018

💔 Build Failed

elasticmachine commented Oct 25, 2018

💔 Build Failed

elasticmachine commented Oct 25, 2018

💔 Build Failed

jasonrhodes commented Oct 25, 2018

elasticmachine commented Oct 25, 2018

💔 Build Failed

formgeist commented Oct 25, 2018

formgeist commented Oct 25, 2018

formgeist commented Oct 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv Oct 25, 2018 • edited

Choose a reason for hiding this comment

sorenlouv Oct 25, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Oct 25, 2018

💔 Build Failed

elasticmachine commented Oct 25, 2018

💔 Build Failed

formgeist commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

jasonrhodes commented Oct 25, 2018

elasticmachine commented Oct 25, 2018

💔 Build Failed

Choose a reason for hiding this comment

elasticmachine commented Oct 26, 2018

💔 Build Failed

elasticmachine commented Oct 26, 2018

💔 Build Failed

jasonrhodes commented Oct 26, 2018

elasticmachine commented Oct 26, 2018

💔 Build Failed

jasonrhodes commented Oct 26, 2018

elasticmachine commented Oct 26, 2018

💔 Build Failed

elasticmachine commented Oct 26, 2018

💚 Build Succeeded

jasonrhodes commented Oct 25, 2018 •

edited

sorenlouv Oct 25, 2018 •

edited

sorenlouv Oct 25, 2018 •

edited