Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kibana.keystore to the configuration directory #25746

Closed
inqueue opened this issue Nov 15, 2018 · 4 comments · Fixed by #57856
Closed

Move kibana.keystore to the configuration directory #25746

inqueue opened this issue Nov 15, 2018 · 4 comments · Fixed by #57856
Assignees
@jbudz
Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team
Projects
Kibana Operations

Comments

@inqueue
Copy link
Member

inqueue commented Nov 15, 2018

Describe the feature:
kibana.keystore resides in data for tar/zip installations and /var/lib/kibana for package installations. Move kibana.keystore to config for tar/zip installations and /etc/kibana for package installations. It would be a breaking change for existing installations using kibana.keystore.

Describe a specific use case for the feature:
This would make the keystore location consistent with Elasticsearch.
@inqueue inqueue added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result labels Nov 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@kobelb
Copy link
Contributor

kobelb commented Nov 15, 2018

/cc @elastic/kibana-operations since this is technically dealing with the distro packages it seems more inline with operations responsibilities, do you agree?

@jbudz jbudz added Team:Operations Team label for Operations Team and removed Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Nov 15, 2018
@jbudz
Copy link
Member

jbudz commented Nov 15, 2018

👍 We need to add a path.conf config and replace all the static, sync checks in server/path. A precursor to that is to make the global config available standalone.

@tylersmalley tylersmalley changed the title move kibana.keystore to the configuration directory Move kibana.keystore to the configuration directory Feb 11, 2019
@jbudz jbudz mentioned this issue Feb 14, 2019
Closed
jbudz added a commit to jbudz/kibana that referenced this issue Feb 18, 2020
@jbudz
Move kibana-keystore from data/ to config/
9443a0a 
This is a breaking change to move the location of kibana-keystore.
Keystores in other stack products live in the config directory, so this
updates our current path to be consistent.

Closes elastic#25746
@jbudz jbudz mentioned this issue Feb 18, 2020
Merged
@tylersmalley
Copy link
Contributor

Move to config directory, fall back to default data directory location to prevent a break in the minor. This fallback should not be present in 8.0.

@kobelb kobelb mentioned this issue Jun 1, 2020
Closed
12 tasks
jbudz added a commit that referenced this issue Jul 13, 2020
@jbudz @elasticmachine
Move kibana-keystore from data/ to config/ (#57856)
94ef03d 
* Move kibana-keystore from data/ to config/

This is a breaking change to move the location of kibana-keystore.
Keystores in other stack products live in the config directory, so this
updates our current path to be consistent.

Closes #25746

* add breaking changes

* update comment

* wip

* fix docs

* read from both keystore locations, write priority to non-deprecated

* note data directory fallback

* add tests for get_keystore

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jbudz added a commit that referenced this issue Jul 13, 2020
@jbudz @elasticmachine
Move kibana-keystore from data/ to config/ (#57856)
c9b6f8a 
* Move kibana-keystore from data/ to config/

This is a breaking change to move the location of kibana-keystore.
Keystores in other stack products live in the config directory, so this
updates our current path to be consistent.

Closes #25746

* add breaking changes

* update comment

* wip

* fix docs

* read from both keystore locations, write priority to non-deprecated

* note data directory fallback

* add tests for get_keystore

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbudz jbudz

Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team
Projects
No open projects
Kibana Operations
8.0
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move kibana-keystore from data/ to config/ jbudz/kibana
5 participants
@tylersmalley @kobelb @jbudz @inqueue @elasticmachine