Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvas] "type" plugins are loaded in server without server-specific builds #27640

Closed
spalger opened this issue Dec 20, 2018 · 2 comments
Closed

[canvas] "type" plugins are loaded in server without server-specific builds #27640

spalger opened this issue Dec 20, 2018 · 2 comments
Labels
chore Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@spalger
Copy link
Contributor

spalger commented Dec 20, 2018 •
edited
Loading

Canvas "type" plugins are currently loaded in the server but there is no way for a server-specific version of the plugins. This makes some sense since the types are supposed to be the same in both the browser and the server, but we have decided to only load server-specific assets in the server to avoid limitations/issues when trying to load code that is targeted for the browser in the server.

We can either change course and find another way to load the browser bundles in the server that doesn't pollute the global scope, or create browser and server specific builds of types, but either way we need to come up with some solution that allows us to remove the --globals option we have to pass to mocha just to get tests passing.
@spalger spalger added chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Dec 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

spalger pushed a commit to spalger/kibana that referenced this issue Dec 20, 2018
[mocha] allow a few globals to get tests passing, see elastic#27640
e58dc9a
spalger pushed a commit to spalger/kibana that referenced this issue Dec 20, 2018
[mocha] allow a few globals to get tests passing, see elastic#27640
5853717
@spalger spalger changed the title [canvas] types plugins are loaded in server without server-specific builds [canvas] "type" plugins are loaded in server without server-specific builds Dec 20, 2018
@cqliu1 cqliu1 added the loe:needs-research This issue requires some research before it can be worked on or estimated label Mar 15, 2019
@nickpeihl nickpeihl added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 26, 2023
@ThomThomson
Copy link
Contributor

Closing this for the time being as we are currently unable to prioritize Canvas-specific tech-debt items. We can reopen this if it starts to cause problems with Kibana operations.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@timroes @spalger @nickpeihl @cqliu1 @ThomThomson @elasticmachine