Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add support for additional aggregations and fields for geohash & boundary layers #28040

Closed
alexfrancoeur opened this issue Jan 3, 2019 · 11 comments
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result

Comments

@alexfrancoeur
Copy link

Similar to to the Elasticsearch documents capabilities we offer to provide additional context to a tooltip, I think our users would like to add additional aggregations and fields when creating an aggregated layer. This will help provide additional context to the layer in the same tooltip.

Elasticsearch documents:
image

@alexfrancoeur alexfrancoeur added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result :GIS App labels Jan 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@nreese
Copy link
Contributor

nreese commented Jan 3, 2019

@alexfrancoeur Can you clarify this request? You can already add additional metric aggregations.

screen shot 2019-01-03 at 2 51 13 pm

It is not possible to add field values since raw documents are not getting returned.

@alexfrancoeur
Copy link
Author

@nreese yes sorry, I didn't mean raw field values just additional aggregations of fields available. Though I could see how string field values in an array may be valuable as well.

At first, I was specifically only looking at the heatmap visualization.

image

Upon further investigation, the Metrics options only seems to be available for the points and grid visualizations of the geohash agg. Would it be possible to add for heatmap as well as any region layers?

image

Also, we may want to involve @gchaps here to provide more context around what the primary metric is and what the secondary metrics are.

@nreese
Copy link
Contributor

nreese commented Jan 4, 2019

Upon further investigation, the Metrics options only seems to be available for the points and grid visualizations of the geohash agg. Would it be possible to add for heatmap as well as any region layers?

@thomasneirynck could probably explain better but this was done on purpose because the heat map combines geohash grid counts to produce the heatmap effect. The combining of values does not make sense with other metric values and the the tooltip is not showing you one grid cell but potentially numerous grid cells.

@nreese
Copy link
Contributor

nreese commented Jan 4, 2019

I didn't mean raw field values just additional aggregations of fields available. Though I could see how string field values in an array may be valuable as well.

I like the idea of showing the results of another aggregation run against the grid cell. Like running a terms aggregation to see the top 10 terms for the cell. I think this would work better than showing raw documents values since the grid cell could represent the results of lots of documents and fetching documents would not scale.

@alexfrancoeur
Copy link
Author

@thomasneirynck could probably explain better but this was done on purpose because the heat map combines geohash grid counts to produce the heatmap effect. The combining of values does not make sense with other metric values and the the tooltip is not showing you one grid cell but potentially numerous grid cells.

Related to the quote / response below, couldn't we add a section for "contextual metrics" or something. The heatmap would still be the primary aggregation whereas the secondary metrics would be providing context to that metric, not affecting the visualization at all. If the heatmap is truly that much different than other the grid or point views then that's fine.

I like the idea of showing the results of another aggregation run against the grid cell. Like running a terms aggregation to see the top 10 terms for the cell. I think this would work better than showing raw documents values since the grid cell could represent the results of lots of documents and fetching documents would not scale.

++ I agree, I'd love to see this and believe we have documented ER's around similar requests. Anything to provide additional context without having to add an additional layer would be beneficial to our users.

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jan 7, 2019

I think for the heatmap layer, we could provide additional metrics, but imho these should be limited to things that are countable, like "sum" or "count", because they give an idea of density of some feature in a given area (which is what heatmaps are for). When you show "averages" or "minimum" values on a heatmap, and those color-blobs start to blend, you really have no idea what you're looking at (ie. what does blending of two "minimum"-values mean???). We can do that sort of styling much better with grid-cells or bubbles, where we are not "blending" values, but just discretely style a polygon or a circle.

+1 on additional aggregations on cells.

@thomasneirynck
Copy link
Contributor

consider embedding visualizations/saved-searches. this would capture most use-cases

e.g. data-table with query, saved-search, ...

@alexfrancoeur
Copy link
Author

++ agreed, but we do have ER's around this for our existing visualizations so I'd like to keep this open. I definitely see the value here, that is also a large reason why @nreese enhanced tilemap plugin is so popular. Additional context.

@nreese
Copy link
Contributor

nreese commented Feb 24, 2020

@alexfrancoeur Can this be closed with #57875?

@nreese
Copy link
Contributor

nreese commented Apr 7, 2020

Closed with #57875.

@nreese nreese closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result
Projects
None yet
Development

No branches or pull requests

4 participants