Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area chart + date_histogram plots extra point on DST #3694

Closed
vikrim1 opened this issue Apr 27, 2015 · 8 comments · Fixed by #4705
Closed

Area chart + date_histogram plots extra point on DST #3694

vikrim1 opened this issue Apr 27, 2015 · 8 comments · Fixed by #4705
Assignees
Labels
bug Fixes for quality problems that affect the customer experience PR sent v4.2.0

Comments

@vikrim1
Copy link

vikrim1 commented Apr 27, 2015

Hi, I think I'm seeing a bug with the date histogram. In the gif below, the sharp drop on March 8 isn't represented in the data returned from the server (screenshot below gif).

kibana-areachartdatehistogrambug

screen shot 2015-04-28 at 11 00 51 am

Request:

{
  "query": {
    "filtered": {
      "query": {
        "query_string": {
          "query": "*",
          "analyze_wildcard": true
        }
      },
      "filter": {
        "bool": {
          "must": [
            {
              "query": {
                "query_string": {
                  "query": "*",
                  "analyze_wildcard": true
                }
              }
            },
            {
              "range": {
                "idxinquiry.performanceDateTime": {
                  "gte": 1398707699271,
                  "lte": 1430243699271
                }
              }
            }
          ],
          "must_not": []
        }
      }
    }
  },
  "size": 0,
  "aggs": {
    "2": {
      "date_histogram": {
        "field": "idxinquiry.eventDateTime",
        "interval": "1w",
        "pre_zone": "-07:00",
        "pre_zone_adjust_large_interval": true,
        "min_doc_count": 1,
        "extended_bounds": {
          "min": 1398707699270,
          "max": 1430243699270
        }
      }
    }
  }
}

Response:

{
  "took": 9,
  "timed_out": false,
  "_shards": {
    "total": 1,
    "successful": 1,
    "failed": 0
  },
  "hits": {
    "total": 5,
    "max_score": 0,
    "hits": []
  },
  "aggregations": {
    "2": {
      "buckets": [
        {
          "key_as_string": "2015-02-23T07:00:00.000Z",
          "key": 1424674800000,
          "doc_count": 1
        },
        {
          "key_as_string": "2015-03-02T07:00:00.000Z",
          "key": 1425279600000,
          "doc_count": 2
        },
        {
          "key_as_string": "2015-03-09T07:00:00.000Z",
          "key": 1425884400000,
          "doc_count": 1
        },
        {
          "key_as_string": "2015-03-16T07:00:00.000Z",
          "key": 1426489200000,
          "doc_count": 1
        }
      ]
    }
  }
}

My guess is that this is somehow related to Daylight Savings Time on March 8. Prior to March 8 the data returned from the server is anchored to 23:00. Starting March 9 (after DST), the data points start being anchored to 00:00. It seems like the visualization is looking for a March 8, 23:00 data point, doesn't find one, and plots it at a value of 0.

Thanks!

@rashidkpc
Copy link
Contributor

Can you post the elasticsearch request and result from the spy panel? You can access via the ^ icon at the bottom of the chart.

@vikrim1
Copy link
Author

vikrim1 commented Apr 28, 2015

Hey Rashid, thanks for the reply. I updated the original description.

@rashidkpc
Copy link
Contributor

Thanks, we've confirmed the issue and are looking into fixes.

@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience v4.1.0 and removed feedback_needed labels Apr 29, 2015
@panda01 panda01 self-assigned this May 4, 2015
@rashidkpc rashidkpc added v4.1.1 and removed v4.1.0 labels May 11, 2015
@spalger spalger added v4.1.2 and removed v4.1.1 labels Jun 29, 2015
@rashidkpc rashidkpc removed the v4.1.2 label Aug 12, 2015
@rashidkpc rashidkpc changed the title Date histogram plots extra point on DST Area chart + date_histogram plots extra point on DST Aug 18, 2015
@rashidkpc
Copy link
Contributor

I can confirm this still occurs, though only happens on the area chart:

aug 18 2015 13 08

@rashidkpc
Copy link
Contributor

Also, there isn't actually another data point there, the chart is just getting dragged down:

aug 18 2015 13 18

@rashidkpc rashidkpc assigned rashidkpc and unassigned panda01 Aug 18, 2015
rashidkpc pushed a commit to rashidkpc/kibana that referenced this issue Aug 18, 2015
@acassaignemondeca
Copy link

Hello,

I've monitored that month buckets labels in histograms sometimes wrongly refer to the end of the previous month instead of the beginning of the current month. I think it is related to this DST bug.

c1
c2

Thanks

@rashidkpc
Copy link
Contributor

See the referenced commit directly before your comment.

@chrisdrusso
Copy link

I'm still seeing this problem in Kibana 4.4.0. Did this fix make it into version 4.4.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience PR sent v4.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants