Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/code/history·ts - Code History browser history can go back while exploring code app in search page, change language filters can go back and forward

[kibanamachine]

A test failed on a tracked branch

        TypeError: Cannot read property 'getVisibleText' of undefined
    at Context.getVisibleText (test/functional/apps/code/history.ts:159:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)
      

First failure: Jenkins Build

[elasticmachine]

Pinging @elastic/kibana-test-triage

[spalger]

@elastic/code looks like this test is racing a little bit, the screenshot shows two facets selected, but since the test doesn't actually wait for anything specifically it's possible that it takes the UI a little too long to update and the find.allByCssSelector('.euiFacetButton--isSelected') selection only gets one item back.

Instead we should probably do something like:

const getSelectedFacets = async () => {
  const selectedButtons = await find.byCssSelector('.euiFacetButton--isSelected')
  return await Promise.all(selectedButtons.map(async btn => await btn.getVisibleText());
}

await retry.try(async () => {
  expect(await getSelectedFacets()).to.eql(['typescript'])
})

// click item

await retry.try(async () => {
  expect(await getSelectedFacets()).to.eql(['typescript', 'javascript'])
})

// go back in history

await retry.try(async () => {
  expect(await getSelectedFacets()).to.eql(['typescript'])
})

[mw-ding]

@spalger so this is specifically for Firefox? do you want me to skip this test for now and then @WangQianliang can take a look?

[mw-ding]

#37914 this looks related.

[dmlemeshko]

Several ideas about wait in tests:

1. Refreshing page can take some time on CI (e.g. latency) and it probably makes sense to wait first for Kibana to be loaded

await browser.refresh();
await PageObjects.header.awaitKibanaChrome()

2. I also notice a spinner coming up before results are loaded:

await testSubjects.waitForDeleted('.euiLoadingSpinner');`

Waiting for the spinner to not be in DOM (probably?) can be used as an indicator of results loading finish.

[kibanamachine]

New failure: Jenkins Build

[kibanamachine]

New failure: Jenkins Build

[kibanamachine]

New failure: Jenkins Build

[spalger]

Search is coming back with no results and there are no facets rendered.

[spalger]

Skipped

master: ae85553
7.x/7.4: 74d79fd

[kibanamachine]

New failure: Jenkins Build

[spalger]

Skipped

master: 08f9435
7.x/7.5: c94ac5d
7.4: daddaa9

[mw-ding]

reenabled by #44547