Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Fit to data should take into account joins #41492

Closed
thomasneirynck opened this issue Jul 18, 2019 · 1 comment · Fixed by #42020
Closed

[Maps] Fit to data should take into account joins #41492

thomasneirynck opened this issue Jul 18, 2019 · 1 comment · Fixed by #42020
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 18, 2019

Since 7.3, features without a corresponding result in the join are now hidden.

The Fit-to-data action does not take that into account, and will fit to all features.

This was intentional, because the maps app does not necessarily know if there are features outside the visible bounds that may have a corresponding result in the join. This could be the case when the source are documents from an index-pattern.

In hindsight, that behavior now seems wonky for the 80% use-case. Usually, the source layer is static, and we know the extent of all features and their left-key properties (e.g. EMS). The fit-2-data should fit what's on screen in those cases. Or at least, this should be the behavior if a join is configured on the vector layer.

@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience discuss [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Jul 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants