[Maps] Fit only on visible features #42020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
thomasneirynck
commented
Jul 25, 2019
| const searchFilters = this._getSearchFilters(dataFilters); | ||
| return await this._source.getBoundsForFilters(searchFilters); | ||
|
|
||
| const isStaticLayer = !this._source.isBoundsAware() || !this._source.isFilterByMapBounds(); |
There was a problem hiding this comment.
this now will only ignore visibility of features for sources that are bounds aware (ie. we can actually query for the entire bounds), and which are filtered based on extent.
E.g. Fit will take into account visibility for an es-doc source layer with all data in the view
thomasneirynck
changed the title
💔 Build Failed |
nreese
approved these changes
Jul 25, 2019
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 26, 2019
This was referenced Jul 26, 2019
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 26, 2019
thomasneirynck
added a commit
that referenced
this pull request
Jul 26, 2019
thomasneirynck
added a commit
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41492